-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: track acknowledgements via a field #507
Conversation
Logic looks good. Test case as Al says, plus we will need an upgrade handler for any existing in process unbondings else they will never complete |
Codecov Report
@@ Coverage Diff @@
## develop #507 +/- ##
===========================================
+ Coverage 56.20% 56.29% +0.09%
===========================================
Files 169 169
Lines 13185 13187 +2
===========================================
+ Hits 7410 7424 +14
+ Misses 5187 5173 -14
- Partials 588 590 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
1. Summary
Fixes # (issue)
UnDelegateMsg
2.Type of change
3. Implementation details
4. How to test/use
5. Checklist
6. Limitations (optional)
7. Future Work (optional)