Parse memo before looking up hash #501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joe-bowman
requested review from
ajansari95,
aljo242,
muku314115 and
cybertronprime
as code owners
joe-bowman
commented
Jul 13, 2023
joe-bowman
commented
Jul 13, 2023
Codecov Report
@@ Coverage Diff @@
## develop #501 +/- ##
===========================================
- Coverage 56.29% 56.27% -0.02%
===========================================
Files 169 169
Lines 13162 13164 +2
===========================================
- Hits 7409 7408 -1
- Misses 5168 5170 +2
- Partials 585 586 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
aljo242
approved these changes
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Summary
Fixes issue with completed unbondings where memo is not parseable after change in format.
2.Type of change
3. Implementation details
ParseMemo field to correctly remove unbond/ prefix.