Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update: v1.4.4-beta.7 upgrade handler #492

Merged
merged 1 commit into from
Jul 11, 2023
Merged

Conversation

ajansari95
Copy link
Contributor

1. Summary

Fixes # (issue)

  • upgrade handler to remove redelegation records emitted before duration > unbondingPeriod

2.Type of change

  • Bug fix (non-breaking change which fixes an issue)

3. Implementation details

4. How to test/use

5. Checklist

  • Does the Readme need to be updated?

6. Limitations (optional)

7. Future Work (optional)

@muku314115
Copy link
Contributor

Do we need all the commented code in upgrades.go?

@ajansari95
Copy link
Contributor Author

Do we need all the commented code in upgrades.go?

yep they are useful and tested handlers that we may require in future

Copy link
Contributor

@joe-bowman joe-bowman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@joe-bowman joe-bowman merged commit e370020 into develop Jul 11, 2023
@joe-bowman joe-bowman deleted the update/dev-release-beta7 branch July 11, 2023 12:35
@ajansari95 ajansari95 mentioned this pull request Jul 13, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants