fix: refactor redelegations distribution logic #490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joe-bowman
requested review from
ajansari95,
aljo242 and
muku314115
as code owners
ajansari95
reviewed
Jul 10, 2023
aljo242
reviewed
Jul 10, 2023
Co-authored-by: Alex Johnson <[email protected]>
|
nits addressed @aljo242 @ajansari95 |
ajansari95
previously approved these changes
Jul 11, 2023
aljo242
reviewed
Jul 11, 2023
Co-authored-by: Alex Johnson <[email protected]>
ajansari95
reviewed
Jul 11, 2023
ajansari95
reviewed
Jul 11, 2023
aljo242
approved these changes
Jul 11, 2023
|
DNM for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Summary
Remove complexity and improve readability in rebalancing.
2.Type of change
3. Implementation details
Rewrite logic for readability and efficiency; don't handle locked tokens twice (potential bug?).
Use specific Delta types instead of trying to reuse ValidatorIntents and casting between Dec and Int all of the place 🤮
CalculateDeltasNew will supercede CalculateDeltas and be renamed with future work. It now outputs two slices, for targets and sources, instead of a single slice containing positive and negative deltas. The latter was far more difficult to reason about and required more complex logic to handle.
6. Limitations
Currently only affects redelegations. Deposit and unbonding logic uses legacy distribution.
7. Future Work (optional)
Update deposits and unbonding to use the new types and logic.