Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix : port and channel for deriving ics rewards denom trace #489

Merged
merged 7 commits into from
Jul 11, 2023

Conversation

ajansari95
Copy link
Contributor

1. Summary

Fixes # (issue)

  • need to use destination channel and port

2.Type of change

  • Bug fix (non-breaking change which fixes an issue)

3. Implementation details

4. How to test/use

5. Checklist

  • Does the Readme need to be updated?

6. Limitations (optional)

7. Future Work (optional)

joe-bowman
joe-bowman previously approved these changes Jul 10, 2023
muku314115
muku314115 previously approved these changes Jul 10, 2023
@aljo242 aljo242 self-requested a review July 10, 2023 11:34
@ajansari95 ajansari95 dismissed stale reviews from muku314115 and joe-bowman via 519bca6 July 11, 2023 09:29
@muku314115
Copy link
Contributor

seems like some ibc_packet_handlers tests are also failing

@joe-bowman
Copy link
Contributor

These tests are failing for the same reason (they use MsgTransfer; might be easier to switch them to something else)

There is also a fmt.Println() somewhere; the tests are echoing out the denom.

joe-bowman
joe-bowman previously approved these changes Jul 11, 2023
Copy link
Contributor

@joe-bowman joe-bowman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aljo242 aljo242 self-requested a review July 11, 2023 14:20
@codecov-commenter
Copy link

Codecov Report

Merging #489 (b5ac7fa) into develop (e2ae3c7) will decrease coverage by 0.02%.
The diff coverage is 33.33%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #489      +/-   ##
===========================================
- Coverage    55.55%   55.54%   -0.02%     
===========================================
  Files          169      169              
  Lines        13096    13101       +5     
===========================================
+ Hits          7276     7277       +1     
- Misses        5242     5245       +3     
- Partials       578      579       +1     
Flag Coverage Δ
unittests 55.54% <33.33%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
x/interchainstaking/keeper/ibc_packet_handlers.go 40.40% <33.33%> (-0.11%) ⬇️

@ajansari95 ajansari95 merged commit dca0e3e into develop Jul 11, 2023
@aljo242 aljo242 deleted the fix/ics_denom_derivation branch July 11, 2023 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants