-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix : port and channel for deriving ics rewards denom trace #489
Conversation
seems like some ibc_packet_handlers tests are also failing |
These tests are failing for the same reason (they use MsgTransfer; might be easier to switch them to something else) There is also a fmt.Println() somewhere; the tests are echoing out the denom. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Codecov Report
@@ Coverage Diff @@
## develop #489 +/- ##
===========================================
- Coverage 55.55% 55.54% -0.02%
===========================================
Files 169 169
Lines 13096 13101 +5
===========================================
+ Hits 7276 7277 +1
- Misses 5242 5245 +3
- Partials 578 579 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
1. Summary
Fixes # (issue)
2.Type of change
3. Implementation details
4. How to test/use
5. Checklist
6. Limitations (optional)
7. Future Work (optional)