Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qck 501 intents as memofield #475

Merged
merged 2 commits into from
Jun 27, 2023
Merged

Conversation

joe-bowman
Copy link
Contributor

1. Summary

Fixes QCK-501

Legacy memoized intent with new memofields appended fails when validator address contains 0xFF

Change makes intents a memorized field.

2.Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • This change requires that the relevant front end changes are deployed at the same time, as legacy memo format will no longer be supported.

3. Implementation details

Memoized intent becomes a length-prefixed memofield, with prefix 0x02, removing the need for a separator (as addresses can contain 0x00 through 0xff so no separator character would be valid).

7. Future Work (optional)

Front end must be updated to prefix the memoized intent with two bytes - [0x02, len(intent_bytes)]

Copy link

@aljo242 aljo242 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

This is a great simplification and improvement of what we already have !

Copy link
Contributor

@ajansari95 ajansari95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm🚢

@ajansari95 ajansari95 merged commit 17c86bf into develop Jun 27, 2023
@ajansari95 ajansari95 deleted the QCK-501-intents-as-memofield branch June 27, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants