Nil unbonding time #473
Merged
Nil unbonding time #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joe-bowman
requested review from
ajansari95,
aljo242 and
muku314115
as code owners
Codecov Report
@@ Coverage Diff @@
## develop #473 +/- ##
===========================================
+ Coverage 55.64% 56.27% +0.63%
===========================================
Files 165 165
Lines 12435 12378 -57
===========================================
+ Hits 6919 6966 +47
+ Misses 5002 4895 -107
- Partials 514 517 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Need to lint and add test case. |
joe-bowman
commented
Jun 22, 2023
added 4 commits
June 23, 2023 13:14
…alid for unbonded validators
…egation is already complete
joe-bowman
force-pushed
the
nil-unbonding-time
branch
from
2856908 to
d6eb665
Compare
|
@ajansari95 @aljo242 @muku314115 - ready for review now! |
aljo242
reviewed
Jun 26, 2023
Co-authored-by: Alex Johnson <[email protected]>
Co-authored-by: Alex Johnson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Summary
Fixes # QCK-500
Permit nil completion times for unbondings and redelegations.
On receipt of nil redelegation completion time, remove the redelegation record.
Additional clean up of Acknowledgement and txResponse unmarshalling.
2.Type of change
3. Implementation details
In HandleBeginUnbonding and HandleBeginRedelegation (ibc_packet_handlers.go) we remove the check for a nil completion time.
In HandleBeginRedelegation, on receipt of nil redelegation completion time, remove the redelegation record.
Use built-in ibc-go methods to inspect failure/sucess of incoming acknowledgement.
Fixes relating to delegation updates on redelegation completion.