Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add format to make proto-gen #472

Merged
merged 2 commits into from
Jun 23, 2023
Merged

Conversation

aljo242
Copy link

@aljo242 aljo242 commented Jun 21, 2023

  • Make sure format is run every timemake proto-gen is run.
  • run make proto-gen

@codecov-commenter
Copy link

Codecov Report

Merging #472 (c53de01) into develop (e0b58ce) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #472   +/-   ##
========================================
  Coverage    55.08%   55.08%           
========================================
  Files          164      164           
  Lines        12358    12358           
========================================
  Hits          6807     6807           
  Misses        5033     5033           
  Partials       518      518           
Flag Coverage Δ
unittests 55.08% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@joe-bowman joe-bowman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@joe-bowman joe-bowman merged commit e9d0ea4 into develop Jun 23, 2023
@joe-bowman joe-bowman deleted the chore/proto-format-make branch June 23, 2023 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants