-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: end point to get intents across all zones for a delegator address #466 #468
Conversation
…tomatic key generation, basechain/basedenom in osmosisparams and updated tvl calculation
… KV store objects; switch to native bech32 decode/encode as we dont expect prefix of pools to match sdk.GetConfig().Bech32Prefix
# Conflicts: # .github/workflows/interchaintest.yaml # app/upgrades/types.go # app/upgrades/upgrades.go # proto/quicksilver/interchainstaking/v1/proposals.proto
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Codecov Report
@@ Coverage Diff @@
## develop #468 +/- ##
===========================================
+ Coverage 55.68% 55.74% +0.05%
===========================================
Files 164 164
Lines 12371 12386 +15
===========================================
+ Hits 6889 6904 +15
Misses 4969 4969
Partials 513 513
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Co-authored-by: Alex Johnson <[email protected]>
…kund/delegatorintents
Other than a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
1. Summary
Fixes # (issue)
Pulled into a new branch and recreated the PR due to merge problems in the previous branch
Built on top of #465
2.Type of change
3. Implementation details
4. How to test/use
5. Checklist
6. Limitations (optional)
7. Future Work (optional)