Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: end point to get intents across all zones for a delegator address #466 #468

Merged
merged 36 commits into from
Jun 23, 2023

Conversation

muku314115
Copy link
Contributor

@muku314115 muku314115 commented Jun 20, 2023

1. Summary

Fixes # (issue)
Pulled into a new branch and recreated the PR due to merge problems in the previous branch
Built on top of #465

2.Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

3. Implementation details

4. How to test/use

5. Checklist

  • Does the Readme need to be updated?

6. Limitations (optional)

7. Future Work (optional)

Joe Bowman and others added 29 commits June 8, 2023 01:49
…tomatic key generation, basechain/basedenom in osmosisparams and updated tvl calculation
… KV store objects; switch to native bech32 decode/encode as we dont expect prefix of pools to match sdk.GetConfig().Bech32Prefix
# Conflicts:
#	.github/workflows/interchaintest.yaml
#	app/upgrades/types.go
#	app/upgrades/upgrades.go
#	proto/quicksilver/interchainstaking/v1/proposals.proto
@muku314115 muku314115 requested a review from joe-bowman as a code owner June 20, 2023 09:51
joe-bowman
joe-bowman previously approved these changes Jun 20, 2023
Copy link
Contributor

@joe-bowman joe-bowman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

x/interchainstaking/keeper/grpc_query.go Outdated Show resolved Hide resolved
x/interchainstaking/keeper/grpc_query.go Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Jun 20, 2023

Codecov Report

Merging #468 (7b9d5ef) into develop (d060410) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #468      +/-   ##
===========================================
+ Coverage    55.68%   55.74%   +0.05%     
===========================================
  Files          164      164              
  Lines        12371    12386      +15     
===========================================
+ Hits          6889     6904      +15     
  Misses        4969     4969              
  Partials       513      513              
Flag Coverage Δ
unittests 55.74% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
x/interchainstaking/keeper/grpc_query.go 82.89% <100.00%> (+1.20%) ⬆️

@joe-bowman
Copy link
Contributor

Other than a make proto-format looks good to go.

Copy link
Contributor

@joe-bowman joe-bowman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@ajansari95 ajansari95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ajansari95 ajansari95 merged commit 27ac85c into develop Jun 23, 2023
@ajansari95 ajansari95 deleted the mukund/delegatorintents branch June 23, 2023 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants