Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upgrade handler and updateZoneProposal #459

Merged
merged 4 commits into from
Jun 14, 2023

Conversation

ajansari95
Copy link
Contributor

1. Summary

Fixes #

  • upgrade handler for migration of zones struct
  • case for is_118 added to updateZoneProposal

2.Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

3. Implementation details

4. How to test/use

5. Checklist

  • Does the Readme need to be updated?

6. Limitations (optional)

7. Future Work (optional)

@ajansari95 ajansari95 changed the title Dev release/v1.4.4 beta 1 fix: upgrade handler and updateZoneProposal Jun 13, 2023
Copy link
Contributor

@joe-bowman joe-bowman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@codecov-commenter
Copy link

Codecov Report

Merging #459 (dabbe0a) into develop (f7603b2) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #459      +/-   ##
===========================================
- Coverage    55.01%   54.98%   -0.03%     
===========================================
  Files          164      164              
  Lines        12331    12337       +6     
===========================================
  Hits          6784     6784              
- Misses        5029     5035       +6     
  Partials       518      518              
Flag Coverage Δ
unittests 54.98% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
x/interchainstaking/keeper/proposal_handler.go 24.18% <0.00%> (-0.70%) ⬇️

@ajansari95 ajansari95 merged commit 7464fad into develop Jun 14, 2023
@joe-bowman joe-bowman deleted the dev-release/v1.4.4-beta-1 branch September 11, 2023 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants