-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: adding test cases for participationrewards #457
Conversation
structure looks good |
Codecov Report
@@ Coverage Diff @@
## develop #457 +/- ##
===========================================
+ Coverage 54.98% 55.66% +0.67%
===========================================
Files 164 164
Lines 12337 12364 +27
===========================================
+ Hits 6784 6882 +98
+ Misses 5035 4969 -66
+ Partials 518 513 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@muku314115 just lint failing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, but requires linting + gofumpt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
1. Summary
Fixes #366
Note: CalcOverallScores never returns the error, instead it logs it and moves on, this behaviour has been changed in the PR to return the error in which case the getZoneScores function will stop on encountering any problem with overall score calculation
2.Type of change
3. Implementation details
4. How to test/use
5. Checklist
6. Limitations (optional)
7. Future Work (optional)