Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: adding test cases for participationrewards #457

Merged
merged 26 commits into from
Jun 23, 2023
Merged

Conversation

muku314115
Copy link
Contributor

@muku314115 muku314115 commented Jun 12, 2023

1. Summary

Fixes #366
Note: CalcOverallScores never returns the error, instead it logs it and moves on, this behaviour has been changed in the PR to return the error in which case the getZoneScores function will stop on encountering any problem with overall score calculation

2.Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

3. Implementation details

4. How to test/use

5. Checklist

  • Does the Readme need to be updated?

6. Limitations (optional)

7. Future Work (optional)

@muku314115 muku314115 marked this pull request as draft June 12, 2023 11:32
@aljo242
Copy link

aljo242 commented Jun 12, 2023

structure looks good

@codecov-commenter
Copy link

codecov-commenter commented Jun 13, 2023

Codecov Report

Merging #457 (c76ffd9) into develop (572115a) will increase coverage by 0.67%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #457      +/-   ##
===========================================
+ Coverage    54.98%   55.66%   +0.67%     
===========================================
  Files          164      164              
  Lines        12337    12364      +27     
===========================================
+ Hits          6784     6882      +98     
+ Misses        5035     4969      -66     
+ Partials       518      513       -5     
Flag Coverage Δ
unittests 55.66% <100.00%> (+0.67%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
x/interchainstaking/keeper/grpc_query.go 81.69% <100.00%> (+1.19%) ⬆️
x/interchainstaking/keeper/withdrawal_record.go 82.87% <100.00%> (+2.44%) ⬆️
x/participationrewards/keeper/rewards_lockup.go 100.00% <100.00%> (ø)
...pationrewards/keeper/rewards_validatorSelection.go 93.90% <100.00%> (+29.29%) ⬆️

... and 1 file with indirect coverage changes

@muku314115 muku314115 marked this pull request as ready for review June 14, 2023 11:23
@aljo242
Copy link

aljo242 commented Jun 15, 2023

@muku314115 just lint failing

@aljo242 aljo242 changed the title adding test cases for participationrewards test: adding test cases for participationrewards Jun 19, 2023
Copy link
Contributor

@joe-bowman joe-bowman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, but requires linting + gofumpt

joe-bowman
joe-bowman previously approved these changes Jun 21, 2023
Copy link
Contributor

@joe-bowman joe-bowman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ajansari95 ajansari95 merged commit d060410 into develop Jun 23, 2023
@ajansari95 ajansari95 deleted the mukund/testing branch June 23, 2023 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

x/participationrewards tests
5 participants