Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: requeued unbonding sends #448

Merged
merged 21 commits into from
Jun 23, 2023
Merged

fix: requeued unbonding sends #448

merged 21 commits into from
Jun 23, 2023

Conversation

aljo242
Copy link

@aljo242 aljo242 commented Jun 7, 2023

1. Summary

Fixes QCK-476

Handle errors for MSgSend via ICA for mature unbondings:

  • if SubmitTx fails, bump completion time by 3 days (currently arbitrary) so we can retry. NOTE, we should probably only do this "retry" a few times instead of infinitely
  • if we receive a failure ack from an ICA MsgSend trigger, requeue the currently unqueued unbonding

2.Type of change

  • Bug fix (non-breaking change which fixes an issue)

@codecov-commenter
Copy link

codecov-commenter commented Jun 7, 2023

Codecov Report

Merging #448 (e208fa8) into develop (e0b58ce) will decrease coverage by 0.14%.
The diff coverage is 32.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #448      +/-   ##
===========================================
- Coverage    55.08%   54.95%   -0.14%     
===========================================
  Files          164      165       +1     
  Lines        12358    12391      +33     
===========================================
+ Hits          6807     6809       +2     
- Misses        5033     5064      +31     
  Partials       518      518              
Flag Coverage Δ
unittests 54.95% <32.00%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
x/interchainstaking/keeper/withdrawal_record.go 82.87% <ø> (ø)
x/interchainstaking/keeper/ibc_packet_handlers.go 34.88% <17.30%> (-0.91%) ⬇️
x/interchainstaking/types/ibc_packet.go 62.50% <33.33%> (-37.50%) ⬇️
x/interchainstaking/keeper/redemptions.go 74.28% <75.00%> (ø)
x/interchainstaking/keeper/delegation.go 89.47% <100.00%> (ø)
x/interchainstaking/keeper/keeper.go 69.80% <100.00%> (ø)
x/interchainstaking/keeper/zones.go 48.95% <100.00%> (ø)
x/interchainstaking/types/withdrawal_record.go 100.00% <100.00%> (ø)

@aljo242 aljo242 marked this pull request as ready for review June 12, 2023 23:02
Copy link
Contributor

@joe-bowman joe-bowman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

joe-bowman
joe-bowman previously approved these changes Jun 20, 2023
Copy link
Contributor

@joe-bowman joe-bowman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@ajansari95 ajansari95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@joe-bowman joe-bowman merged commit a82e4b2 into develop Jun 23, 2023
@joe-bowman joe-bowman deleted the fix/requeue-failed-unbond branch September 11, 2023 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants