Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/add msgs per tx to proposals #365

Merged
merged 5 commits into from
Mar 28, 2023
Merged

Feature/add msgs per tx to proposals #365

merged 5 commits into from
Mar 28, 2023

Conversation

joe-bowman
Copy link
Contributor

@joe-bowman joe-bowman commented Mar 28, 2023 •
edited
Loading

1. Summary

Fixes QCK-236

2.Type of change

  • New feature (non-breaking change which adds functionality)

3. Implementation details

  • Added message_per_tx to protobuf for RegisterZoneProposal
  • Add message_per_tx > 0 check to cli, and validateBasic
  • Add message_per_tx to the fields that can be updated by UpdateZoneProposal
  • Add validateBasic test
  • Retract v1.2.8

@aljo242 aljo242 changed the base branch from develop to main March 28, 2023 14:56
@joe-bowman joe-bowman force-pushed the feature/add-msgs-per-tx-to-proposals branch from 83492a8 to f589ffd Compare March 28, 2023 14:59
ajansari95
ajansari95 reviewed Mar 28, 2023
View reviewed changes
Copy link
Contributor

@ajansari95 ajansari95 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog please.

ajansari95
ajansari95 previously approved these changes Mar 28, 2023
View reviewed changes
Copy link
Contributor

@ajansari95 ajansari95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

ajansari95
ajansari95 approved these changes Mar 28, 2023
View reviewed changes
Copy link
Contributor

@ajansari95 ajansari95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@joe-bowman joe-bowman merged commit ee5349e into main Mar 28, 2023
@aljo242 aljo242 deleted the feature/add-msgs-per-tx-to-proposals branch March 28, 2023 17:58
@faddat faddat mentioned this pull request May 8, 2023
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajansari95 ajansari95 ajansari95 approved these changes

@aljo242 aljo242 aljo242 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joe-bowman @aljo242 @ajansari95