Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: backport lint fixes to main #363

Merged
merged 5 commits into from
Mar 27, 2023
Merged

chore: backport lint fixes to main #363

merged 5 commits into from
Mar 27, 2023

Conversation

aljo242
Copy link

@aljo242 aljo242 commented Mar 27, 2023

1. Summary

Fixes QCK-233
Fixes QCK-232

2.Type of change

  • Bug fix (non-breaking change which fixes an issue)

3. Implementation details

  • Backport 85fc8f7
  • add linting and format tools built in
  • update dependencies
  • add retract in go.mod for known bugged release

@aljo242 aljo242 mentioned this pull request Mar 27, 2023
1 task
@codecov-commenter
Copy link

codecov-commenter commented Mar 27, 2023

Codecov Report

Merging #363 (2088dea) into main (ce53635) will increase coverage by 0.17%.
The diff coverage is 48.05%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #363      +/-   ##
==========================================
+ Coverage   53.22%   53.40%   +0.17%     
==========================================
  Files         148      146       -2     
  Lines       11505    11461      -44     
==========================================
- Hits         6124     6121       -3     
+ Misses       4968     4934      -34     
+ Partials      413      406       -7     
Flag Coverage Δ
unittests 53.40% <48.05%> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
app/app.go 85.02% <ø> (ø)
app/config.go 0.00% <0.00%> (ø)
cmd/quicksilverd/bulk_airdrop.go 9.67% <ø> (ø)
cmd/quicksilverd/forceprune.go 5.67% <0.00%> (+0.23%) ⬆️
cmd/quicksilverd/genairdrop.go 9.48% <ø> (ø)
cmd/quicksilverd/root.go 58.90% <ø> (ø)
wasmbinding/message_plugin.go 5.29% <0.00%> (ø)
wasmbinding/query_plugin.go 35.71% <ø> (ø)
x/airdrop/keeper/hooks.go 0.00% <0.00%> (ø)
x/claimsmanager/types/claimsmanager.go 100.00% <ø> (ø)
... and 41 more

ajansari95
ajansari95 previously approved these changes Mar 27, 2023
Copy link
Contributor

@ajansari95 ajansari95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@joe-bowman joe-bowman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@joe-bowman
Copy link
Contributor

@ajansari95 can you re-review this please?

Copy link
Contributor

@ajansari95 ajansari95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ajansari95 ajansari95 merged commit 43c1450 into main Mar 27, 2023
@ajansari95 ajansari95 deleted the chore/main-lint branch March 27, 2023 16:44
@faddat faddat mentioned this pull request May 8, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants