Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: include protobuf commands in makefile #360

Merged
merged 1 commit into from
Mar 24, 2023
Merged

chore: include protobuf commands in makefile #360

merged 1 commit into from
Mar 24, 2023

Conversation

johnletey
Copy link
Contributor

1. Summary

Follow up on #359.

2.Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

3. Implementation details

4. How to test/use

5. Checklist

  • Does the Readme need to be updated?

6. Limitations (optional)

7. Future Work (optional)

ajansari95
ajansari95 approved these changes Mar 24, 2023
View reviewed changes
Copy link
Contributor

@ajansari95 ajansari95 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you @johnletey 🚀

@ajansari95 ajansari95 merged commit 118cfe4 into quicksilver-zone:develop Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajansari95 ajansari95 ajansari95 approved these changes

@aljo242 aljo242 aljo242 approved these changes

@joe-bowman joe-bowman Awaiting requested review from joe-bowman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@johnletey @aljo242 @ajansari95