Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: don't include simulation helpers in coverage report #345

Merged
merged 5 commits into from
Mar 21, 2023

Conversation

aljo242
Copy link

@aljo242 aljo242 commented Mar 12, 2023

1. Summary

Add DONTCOVER annotations to simulation files as they are test utility functions.

@aljo242 aljo242 changed the title chore: chore: don't include simulation helpers in coverage report Mar 12, 2023
Copy link
Contributor

@joe-bowman joe-bowman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@ajansari95 ajansari95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aljo242 aljo242 merged commit 51efdcf into main Mar 21, 2023
@aljo242 aljo242 deleted the test/coverage branch March 21, 2023 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants