Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: local claim validation #342

Merged
merged 11 commits into from
Mar 10, 2023
Merged

Conversation

joe-bowman
Copy link
Contributor

@joe-bowman joe-bowman commented Mar 10, 2023

1. Summary

Fixes QCK-29

2.Type of change

  • Bug fix (non-breaking change which fixes an issue)

3. Implementation details

  • fixes off by one issue in epoch self consensus state generation that breaks local claim validation
  • adds test cases covering local claims with proof validation enabled
  • bump cosmos-sdk and tendermint

4. How to test/use

  • submission of a claim for qassets on the local chain will now succeed.

@codecov-commenter
Copy link

codecov-commenter commented Mar 10, 2023

Codecov Report

Merging #342 (be715a8) into main (607f847) will decrease coverage by 2.34%.
The diff coverage is 18.33%.

❗ Current head be715a8 differs from pull request most recent head 23a22dd. Consider uploading reports for the commit 23a22dd to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #342      +/-   ##
==========================================
- Coverage   54.46%   52.12%   -2.34%     
==========================================
  Files         157      171      +14     
  Lines       11689    12353     +664     
==========================================
+ Hits         6366     6439      +73     
- Misses       4870     5460     +590     
- Partials      453      454       +1     
Flag Coverage Δ
unittests 52.12% <18.33%> (-2.34%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
app/config.go 0.00% <0.00%> (ø)
app/export.go 10.88% <ø> (-7.25%) ⬇️
cmd/quicksilverd/forceprune.go 5.44% <ø> (ø)
simulation/config.go 56.41% <ø> (ø)
simulation/helpers.go 0.00% <ø> (ø)
simulation/state.go 0.00% <0.00%> (ø)
x/mint/simulation/genesis.go 0.00% <0.00%> (ø)
x/tokenfactory/keeper/keeper.go 92.30% <ø> (ø)
x/participationrewards/module.go 52.23% <11.11%> (-6.39%) ⬇️
x/claimsmanager/keeper/keeper.go 72.22% <50.00%> (+16.66%) ⬆️
... and 9 more

... and 8 files with indirect coverage changes

utils/coins.go Outdated Show resolved Hide resolved
x/participationrewards/keeper/msg_server_test.go Outdated Show resolved Hide resolved
utils/coins.go Outdated Show resolved Hide resolved
x/participationrewards/keeper/submodule_liquid.go Outdated Show resolved Hide resolved
cmd/quicksilverd/forceprune.go Outdated Show resolved Hide resolved
@aljo242 aljo242 changed the title Bugfix/qck 29 local claim validation fix: local claim validation Mar 10, 2023
Co-authored-by: Alex Johnson <[email protected]>
Copy link
Contributor

@ajansari95 ajansari95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

golangci-lint failing otherise looks good

Copy link
Contributor

@ajansari95 ajansari95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aljo242 aljo242 merged commit 7d5d28b into main Mar 10, 2023
@joe-bowman joe-bowman deleted the bugfix/qck-29-local-claim-validation branch March 10, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants