refactor: interchainstaking keeper

[aljo242]

1. Summary

Cleanup work done while working on interchainstaking simulation.

2.Type of change

• refactor

3. Implementation details

• update function signatures to be clearer and consistent
• factor out some TM state checking logic into another function
• update variable names to be clearer
• add more comments
• wrap errors
• format
• add context to logging

[codecov-commenter]

Codecov Report

Merging #341 (d3031a7) into main (8c206d9) will decrease coverage by 0.07%.
The diff coverage is 48.74%.

@@            Coverage Diff             @@
##             main     #341      +/-   ##
==========================================
- Coverage   53.10%   53.04%   -0.07%     
==========================================
  Files         163      163              
  Lines       12054    12121      +67     
==========================================
+ Hits         6401     6429      +28     
- Misses       5200     5239      +39     
  Partials      453      453              

Flag	Coverage Δ
unittests	53.04% <48.74%> (-0.07%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
x/interchainstaking/keeper/abci.go	42.22% <0.00%> (ø)
x/interchainstaking/types/ibc_packet.go	100.00% <ø> (ø)
x/interchainstaking/keeper/callbacks.go	33.14% <3.03%> (-0.57%)	⬇️
x/interchainstaking/keeper/receipt.go	24.66% <3.92%> (-1.28%)	⬇️
x/interchainstaking/keeper/ibc_packet_handlers.go	31.83% <25.00%> (ø)
x/interchainstaking/keeper/msg_server.go	52.68% <57.14%> (-1.48%)	⬇️
x/interchainstaking/keeper/intent.go	73.09% <64.17%> (+1.58%)	⬆️
x/interchainstaking/keeper/hooks.go	66.15% <65.67%> (-4.31%)	⬇️
x/interchainstaking/keeper/redemptions.go	82.88% <87.17%> (-0.28%)	⬇️
x/airdrop/keeper/claim_handler.go	59.31% <100.00%> (ø)
... and 4 more

[joe-bowman]

lgtm

[ajansari95]

LGTM (checks)