Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix tools in Makefile #335

Merged
merged 8 commits into from
Mar 21, 2023
Merged

chore: fix tools in Makefile #335

merged 8 commits into from
Mar 21, 2023

Conversation

aljo242
Copy link

@aljo242 aljo242 commented Mar 6, 2023

1. Summary

Closes #297
Closes #348

Modifies the Makefile so that targets like lint and format can automatically pull down the required tools and run them by using go run. On systems where he tools are already installed, the tools will just be run from GOPATH.

Additional fixes:

  • runs make format
  • use the $(DOCKER) variable consistently throughout Makefile
  • silence some make commands
  • remove dead test targets

joe-bowman
joe-bowman previously approved these changes Mar 6, 2023
Copy link
Contributor

@joe-bowman joe-bowman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

joe-bowman
joe-bowman previously approved these changes Mar 15, 2023
Copy link
Contributor

@joe-bowman joe-bowman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@joe-bowman joe-bowman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@ajansari95 ajansari95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aljo242 aljo242 merged commit 0b79d81 into main Mar 21, 2023
@aljo242 aljo242 deleted the chore/toolfix branch March 21, 2023 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do you support Go 1.20 ? Makefile test targets are out of date
3 participants