Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use constant interchainstaking begin block interval #331

Merged
merged 5 commits into from
Mar 3, 2023

Conversation

aljo242
Copy link

@aljo242 aljo242 commented Mar 3, 2023

1. Summary

Using a constant is more clear. Do we want this to be a static constant or something that has more control like a param?

@aljo242 aljo242 changed the title refactor: use constant for redemptions GC interval refactor: use constant interchainstaking begin block interval Mar 3, 2023
@codecov-commenter
Copy link

codecov-commenter commented Mar 3, 2023

Codecov Report

Merging #331 (6c82fe2) into main (f8a8c24) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #331   +/-   ##
=======================================
  Coverage   55.17%   55.17%           
=======================================
  Files         152      152           
  Lines       12050    12050           
=======================================
  Hits         6648     6648           
  Misses       4921     4921           
  Partials      481      481           
Flag Coverage Δ
unittests 55.17% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
x/interchainstaking/keeper/abci.go 39.53% <0.00%> (ø)

Copy link
Contributor

@joe-bowman joe-bowman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@ajansari95 ajansari95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joe-bowman joe-bowman merged commit f067363 into main Mar 3, 2023
@joe-bowman joe-bowman deleted the chore/cons-ics branch March 3, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants