refactor: interchainstaking/keeper

[aljo242]

1. Summary

interchainstaking is our most complicated module and package in the codebase. This PR attempts to refactor and modularize the keeper package. Maintenance like this can help us with adding features, instrumentation and testing moving forward.

2.Type of change

• refactor

3. Implementation details

• move non-keeper methods to the types package
• modularize function calls more
• unify keeper function signatures so that they are all pointer receivers
• pass Zone struct as a pointer to our functions

4. How to test/use

Verify functionality is not modified by this PR.

5. Checklist

• Does the Readme need to be updated?

6. Limitations (optional)

7. Future Work (optional)

[joe-bowman]

Any idea why no checks have run here, @aljo242 ?

[aljo242]

Any idea why no checks have run here, @aljo242 ?

Was wondering the same thing - no idea

[aljo242]

@joe-bowman running now after I merged main. Weird

[codecov-commenter]

Codecov Report

Merging #330 (c7d3473) into main (f067363) will decrease coverage by 0.88%.
The diff coverage is 67.52%.

@@            Coverage Diff             @@
##             main     #330      +/-   ##
==========================================
- Coverage   55.33%   54.46%   -0.88%     
==========================================
  Files         155      157       +2     
  Lines       11649    11689      +40     
==========================================
- Hits         6446     6366      -80     
- Misses       4745     4870     +125     
+ Partials      458      453       -5     

Flag	Coverage Δ
unittests	54.46% <67.52%> (-0.88%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
app/app.go	58.79% <0.00%> (ø)
x/interchainstaking/types/keys.go	47.82% <0.00%> (-52.18%)	⬇️
...pationrewards/keeper/rewards_validatorSelection.go	78.57% <ø> (ø)
x/interchainstaking/types/rebalance.go	28.87% <28.87%> (ø)
x/interchainstaking/keeper/receipt.go	25.94% <41.66%> (-0.70%)	⬇️
x/interchainstaking/keeper/ibc_packet_handlers.go	31.83% <58.33%> (+0.46%)	⬆️
x/interchainstaking/keeper/zones.go	44.14% <58.82%> (ø)
x/interchainstaking/keeper/abci.go	42.22% <60.00%> (+2.68%)	⬆️
x/interchainstaking/keeper/proposal_handler.go	25.90% <63.63%> (+0.50%)	⬆️
x/airdrop/keeper/claim_handler.go	59.31% <66.66%> (ø)
... and 17 more

[joe-bowman]

@aljo242 bunch of conflicts now!

[joe-bowman]

lgtm

[joe-bowman]

@ajansari95

[ajansari95]

LGTM