Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ci #329

Merged
merged 3 commits into from
Mar 1, 2023
Merged

fix: ci #329

merged 3 commits into from
Mar 1, 2023

Conversation

ajansari95
Copy link
Contributor

fix failing ci

@ajansari95 ajansari95 requested a review from joe-bowman March 1, 2023 13:34
@codecov-commenter
Copy link

codecov-commenter commented Mar 1, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release/v1.2.x@8be21c6). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                @@
##             release/v1.2.x     #329   +/-   ##
=================================================
  Coverage                  ?   53.41%           
=================================================
  Files                     ?      148           
  Lines                     ?    11367           
  Branches                  ?        0           
=================================================
  Hits                      ?     6072           
  Misses                    ?     4883           
  Partials                  ?      412           
Flag Coverage Δ
unittests 53.41% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ajansari95 ajansari95 requested a review from aljo242 March 1, 2023 13:37
@ajansari95 ajansari95 changed the title Ci/fix fix: ci Mar 1, 2023
Copy link

@aljo242 aljo242 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aljo242 aljo242 added the ci label Mar 1, 2023
Copy link
Contributor

@joe-bowman joe-bowman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ajansari95 ajansari95 merged commit 6b75d9d into release/v1.2.x Mar 1, 2023
@ajansari95 ajansari95 deleted the ci/fix branch March 1, 2023 13:44
@faddat faddat mentioned this pull request May 8, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants