Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: x/interchainstaking/types #324

Merged
merged 13 commits into from
Mar 3, 2023
Merged

test: x/interchainstaking/types #324

merged 13 commits into from
Mar 3, 2023

Conversation

aljo242
Copy link

@aljo242 aljo242 commented Feb 27, 2023

1. Summary

Add some tests to x/interchainstaking/types:

2.Type of change

  • New tests (non-breaking change which adds tests)

3. Implementation details

4. How to test/use

5. Checklist

  • Does the Readme need to be updated?

6. Limitations (optional)

7. Future Work (optional)

@codecov-commenter
Copy link

codecov-commenter commented Feb 27, 2023

Codecov Report

Merging #324 (a3faf12) into main (f865ec1) will increase coverage by 0.88%.
The diff coverage is 64.17%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #324      +/-   ##
==========================================
+ Coverage   55.17%   56.05%   +0.88%     
==========================================
  Files         152      153       +1     
  Lines       12050    12057       +7     
==========================================
+ Hits         6648     6759     +111     
+ Misses       4921     4828      -93     
+ Partials      481      470      -11     
Flag Coverage Δ
unittests 56.05% <64.17%> (+0.88%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
x/interchainstaking/keeper/receipt.go 26.63% <0.00%> (+0.72%) ⬆️
x/interchainstaking/types/genesis.go 0.00% <0.00%> (ø)
x/interchainstaking/types/proposals.go 41.66% <42.42%> (+29.90%) ⬆️
x/interchainstaking/types/params.go 42.52% <82.35%> (+42.52%) ⬆️
x/interchainstaking/types/keys.go 100.00% <100.00%> (+48.00%) ⬆️
x/interchainstaking/types/receipt.go 100.00% <100.00%> (ø)
x/interchainstaking/types/validator.go 89.47% <100.00%> (+28.91%) ⬆️
x/interchainstaking/types/zones.go 72.29% <0.00%> (+2.02%) ⬆️
x/interchainstaking/types/delegation.go 91.04% <0.00%> (+23.88%) ⬆️
... and 3 more

joe-bowman
joe-bowman previously approved these changes Mar 1, 2023
Copy link
Contributor

@joe-bowman joe-bowman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aljo242 aljo242 marked this pull request as ready for review March 1, 2023 16:22
@aljo242 aljo242 requested a review from ajansari95 as a code owner March 1, 2023 16:22
@aljo242 aljo242 requested a review from joe-bowman March 1, 2023 16:22
Copy link
Contributor

@ajansari95 ajansari95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@joe-bowman joe-bowman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@joe-bowman joe-bowman merged commit f5897f4 into main Mar 3, 2023
@joe-bowman joe-bowman deleted the test/icatypes branch March 3, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants