Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: x/mint/types #322

Merged
merged 7 commits into from
Mar 1, 2023
Merged

test: x/mint/types #322

merged 7 commits into from
Mar 1, 2023

Conversation

aljo242
Copy link

@aljo242 aljo242 commented Feb 27, 2023

1. Summary

Add some tests to x/mint/types:

  • genesis validation
  • minter validation
  • params validation
  • refactor methods signatures to be in line with our other modules

2.Type of change

  • New tests (non-breaking change which adds tests)

@codecov-commenter
Copy link

codecov-commenter commented Feb 27, 2023

Codecov Report

Merging #322 (d897f2e) into main (0635179) will increase coverage by 0.76%.
The diff coverage is 83.87%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #322      +/-   ##
==========================================
+ Coverage   54.40%   55.17%   +0.76%     
==========================================
  Files         152      152              
  Lines       12042    12050       +8     
==========================================
+ Hits         6552     6648      +96     
+ Misses       5030     4921     -109     
- Partials      460      481      +21     
Flag Coverage Δ
unittests 55.17% <83.87%> (+0.76%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
x/mint/types/params.go 42.64% <64.28%> (+42.64%) ⬆️
x/mint/types/genesis.go 100.00% <100.00%> (+100.00%) ⬆️
x/mint/types/minter.go 100.00% <100.00%> (+100.00%) ⬆️

Copy link
Contributor

@joe-bowman joe-bowman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@ajansari95 ajansari95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aljo242 aljo242 merged commit 6367496 into main Mar 1, 2023
@aljo242 aljo242 deleted the test/minttypes branch March 1, 2023 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants