Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove log line #319

Merged
merged 2 commits into from
Mar 1, 2023
Merged

fix: remove log line #319

merged 2 commits into from
Mar 1, 2023

Conversation

aljo242
Copy link

@aljo242 aljo242 commented Feb 23, 2023

1. Summary

Remove an accidentally included fmt.Println() call.

2.Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

@aljo242 aljo242 changed the title fix: remove fix: remove log line Feb 23, 2023
@codecov-commenter
Copy link

codecov-commenter commented Feb 23, 2023

Codecov Report

Merging #319 (fb72816) into main (5e295f8) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #319   +/-   ##
=======================================
  Coverage   54.40%   54.40%           
=======================================
  Files         152      152           
  Lines       12042    12042           
=======================================
  Hits         6552     6552           
  Misses       5030     5030           
  Partials      460      460           
Flag Coverage Δ
unittests 54.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@joe-bowman joe-bowman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@joe-bowman joe-bowman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you ;)

Copy link
Contributor

@ajansari95 ajansari95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ajansari95 ajansari95 merged commit efbc1f8 into main Mar 1, 2023
@joe-bowman joe-bowman deleted the fix/remove-log-line branch March 1, 2023 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants