Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue with negative available per validator #316

Merged
merged 8 commits into from
Feb 23, 2023

Conversation

joe-bowman
Copy link
Contributor

@joe-bowman joe-bowman commented Feb 22, 2023

1. Summary

  • add guards against negative completion times (should not be possible now, but belt and braces)
  • panic (hooks and tx, so safe) on negative allocations
  • fixes a test that no longer generates an error, given no satisfiable unbondings
  • adds a check on msgResponseType if its not empty string then 46 otherwise 45

2.Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

3. Implementation details

Add guards against invalid completion times.
Panic on negative unbonding allocation.

@ajansari95 ajansari95 marked this pull request as ready for review February 22, 2023 19:29
@ajansari95
Copy link
Contributor

Closes comments from #313 for table based check and closes the PR

@ajansari95 ajansari95 mentioned this pull request Feb 22, 2023
2 tasks
Copy link
Contributor Author

@joe-bowman joe-bowman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor bits but otherwise good

Copy link
Contributor

@ajansari95 ajansari95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joe-bowman joe-bowman merged commit 5e295f8 into main Feb 23, 2023
@joe-bowman joe-bowman deleted the bug-negative-available branch March 1, 2023 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants