feat: add simulations part 1 #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 21, 2023 09:42
added 11 commits
February 21, 2023 11:21
joe-bowman
reviewed
Feb 24, 2023
joe-bowman
previously approved these changes
Feb 24, 2023
added 2 commits
March 3, 2023 06:02
joe-bowman
reviewed
Mar 3, 2023
joe-bowman
reviewed
Mar 3, 2023
joe-bowman
reviewed
Mar 3, 2023
|
@aljo242 merging |
added 3 commits
March 3, 2023 10:16
|
@ajansari95 looks like the sim did not run. Merge conflicts resolved |
ajansari95
reviewed
Mar 3, 2023
|
@joe-bowman it dismiised your review as stale. |
|
sim didn't run? @ajansari95 @aljo242 |
|
@ajansari95 @joe-bowman - action should be fixed now |
yup looking in if you add labels on already existing PR will it work or not. |
|
Yeah I think this method should allow us to add the label at a later time - which is better |
|
@ajansari95 - your review was dismissed here ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Summary
Part of #294
Fixes QCK-112
Fixes QCK-105
Fixes QCK-106
Fixes QCK-104
Add simulation testing back into the app and create a basic implementation of
x/mintsimulation.x/epochssimulation already existed, so it is just added back in.The remaining module simulations will be added piecemeal for each module and tracked in separate issues.
2.Type of change
Please delete options that are not relevant.
3. Implementation details
/simulation/simulation/simtypes(adapted from https://github.com/osmosis-labs/osmosis/tree/main/simulation/simtypes)app/simulationx/{moduleName}/simulationfor each of our custom modulessimulation.ymlworkflow which runs a lightweight version ofTestSimNonDeterminism4. How to test/use
make test-sim-*targets5. Checklist
6. Limitations (optional)
Existing simulation "scenarios" need to be thoroughly checked.
7. Future Work (optional)
Add more sim functionality as needed