-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add tools.go
#310
chore: add tools.go
#310
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## main #310 +/- ##
=======================================
Coverage 54.40% 54.40%
=======================================
Files 152 152
Lines 12042 12042
=======================================
Hits 6552 6552
Misses 5030 5030
Partials 460 460
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
1. Summary
Adds a
tools
pkg which allows us to require development tools likegolangci-lint
andgofumpt
in ourgo.mod
file. This is potentially useful for new devs working with our code who may not have the tools installed. Otherwise, they would receive amake
target fail if they tried to run something likemake format
without the tool installed.This addition also lets us ensure that all developers are using the same minimum version for said tools.
2.Type of change
Please delete options that are not relevant.
3. Implementation details
tools/tools.go
4. How to test/use
go clean -modcache
and remove tools likegofumpt
go mod tidy
and then try to use tools again