V046 responses fix #304
Merged
V046 responses fix #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests are passing, but failing vulnchecker on go1.19 vulns; we can ignore these for this release. Bump to v1.20 needs sufficient testing to ensure determinism |
agreed |
prakritimalik
requested review from
prakritimalik
and removed request for
prakritimalik
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Summary
Fixes v0.46 MsgResponses unmarshalling.
2.Type of change
Please delete options that are not relevant.
3. Implementation details
Use any.GetValue() + proto.Unmarshal() instead of trying to unpack type without appropriate interface.
4. How to test/use
Added v45 and v46 response unmarshalling tests.