Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix deposit address setWithdrawalAddress callback #284

Merged
merged 2 commits into from
Jan 19, 2023
Merged

Conversation

ajansari95
Copy link
Contributor

1. Summary

Fixes:

  • Fixes the logic to set ICA account withdrawal address. Introduced by fixing a typo in v1.2.1

2.Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

3. Implementation details

4. How to test/use

5. Checklist

  • Does the Readme need to be updated?
  • Have tests been added to cover the change

6. Limitations (optional)

N/A

7. Future Work (optional)

N/A

@ajansari95 ajansari95 requested a review from joe-bowman January 19, 2023 16:26
Copy link
Contributor

@joe-bowman joe-bowman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ajansari95 ajansari95 merged commit d4a45f7 into main Jan 19, 2023
@joe-bowman joe-bowman deleted the release/1.2.2 branch January 19, 2023 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants