Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: add module specs #278

Merged
merged 2 commits into from
Jan 6, 2023
Merged

Docs: add module specs #278

merged 2 commits into from
Jan 6, 2023

Conversation

zanicar
Copy link
Contributor

@zanicar zanicar commented Jan 6, 2023

1. Summary

Module specifications added.

2.Type of change

Documentation update;
Code comments added, updated or deleted.

3. Implementation details

N/A

4. How to test/use

x/{module}/spec/README.md

5. Checklist

6. Limitations (optional)

N/A

7. Future Work (optional)

A few small sections may need some elaboration.

- fixed incorrect comments;
- added some missing comments;
- removed superflous comments;
- updated airdrop spec;
- added claimsmanager spec;
- added spec template for interchainqueries;
- fixed event emission in interchainstaking;
- added interchainstaking spec;
- added spec module template;
- added participationrewards spec;
Copy link
Contributor

@joe-bowman joe-bowman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@ajansari95 ajansari95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joe-bowman joe-bowman merged commit eb48a81 into main Jan 6, 2023
@joe-bowman joe-bowman deleted the docs-specs branch January 6, 2023 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants