cleanup: remove ic-test

[ajansari95]

1. Summary

Fixes # (issue)

• Removes stale/redundant interchain-tests

2.Type of change

• Cleanup

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

3. Implementation details

• removes test/interchaintest/*
• relevant ci actions removed
• make file cleanup

4. How to test/use

5. Checklist

• Does the Readme need to be updated?

6. Limitations (optional)

7. Future Work (optional)

• Incorporate working ic-test with a better approach

Summary by CodeRabbit

• New Features

  • Updated Go version to 1.22.4 for improved performance and security.

• Bug Fixes

  • Addressed vulnerabilities by updating dependencies, including gin-gonic/gin and keyring.

• Chores

  • Removed outdated interchain testing framework and associated targets from the Makefile.
  • Deleted obsolete test files related to interchain functionality.
  • Updated link checker workflow for better issue management.

These changes streamline the testing process and enhance the overall stability of the application.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
quicksilver	❌ Failed (Inspect)			Oct 9, 2024 9:32am

[coderabbitai]

Walkthrough

The changes involve the deletion of a GitHub Actions workflow and several Makefile targets related to interchain testing, indicating a shift in the testing strategy for the Quicksilver project. Additionally, the Go module file has been updated to a newer version and modified to reflect changes in dependencies. Several test files related to interchain functionality have also been removed, indicating a significant reduction in testing coverage for that area.

Changes

File/Path	Change Summary
.github/workflows/interchaintest.yaml	Deleted file defining a GitHub Actions workflow for Docker image creation and end-to-end tests, including jobs for building, pushing, and testing.
Makefile	Removed multiple targets related to interchain testing, indicating a significant change in testing strategy.
go.mod	Updated Go version from 1.22.2 to 1.22.4; modified dependencies in the require and replace blocks without altering overall structure.
test/interchaintest/*	Deleted multiple test files and associated functions related to Quicksilver interchain functionality, reducing testing coverage in that area.
.github/workflows/md-link-checker.yml	Updated link checker workflow to use [email protected], modified issue management parameters, and enhanced the close-issue message.

Suggested labels

ci, docs

Suggested reviewers

• faddat
• joe-bowman
• minhngoc274

Poem

🐰 In the garden where changes bloom,
The tests have vanished, leaving room.
With Docker dreams and Go in flight,
We'll hop along to new delight!
A fresh path calls, let’s take our chance,
In code we trust, let’s start the dance! 🌼

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)

.github/workflows/md-link-checker.yml (1)

Line range hint 1-41: Consider adjusting issue management and authentication method.

While the overall workflow looks good, there are two points to consider:

1. Issue Management: The days-before-issue-stale and days-before-issue-close are both set to 0, which means issues are immediately marked as stale and closed. This might be too aggressive and could potentially close issues before they're properly addressed or reviewed. Consider adding a short delay (e.g., 1-3 days) to allow for human intervention if needed.

2. Authentication: The workflow is using a Personal Access Token (GH_PAT) for authentication. While this is valid, consider using a GitHub App token instead for enhanced security and more granular permissions management.

Here's a suggested change for the issue management:

-          days-before-issue-stale: 0
-          days-before-issue-close: 0
+          days-before-issue-stale: 1
+          days-before-issue-close: 1

Regarding authentication, you may want to explore setting up a GitHub App for this repository and using its token instead of a PAT. This change would require modifications to how the token is obtained and used in the workflow.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between b2cf3ec and 6ff5777.

📒 Files selected for processing (1)

• .github/workflows/md-link-checker.yml (1 hunks)

🧰 Additional context used

🔇 Additional comments (1)

.github/workflows/md-link-checker.yml (1)

28-28: Approve the Lychee action update with a recommendation.

The update to Lychee action v2.0.0 is a good practice to stay current with the latest features and improvements. However, as this is a major version update, it's important to ensure compatibility with the existing workflow.

Please verify the following:

1. Review the changelog for Lychee action v2.0.0 to understand any breaking changes or new features.
2. Ensure that the new version is compatible with the current workflow configuration.
3. Consider if any new features introduced in v2.0.0 could be beneficial to incorporate into the workflow.

You can find the changelog and release notes for Lychee action v2.0.0 at: https://github.com/lycheeverse/lychee-action/releases/tag/v2.0.0

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.41%. Comparing base (655d80e) to head (b74d4b7).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1727   +/-   ##
=======================================
  Coverage   63.41%   63.41%           
=======================================
  Files         194      194           
  Lines       13436    13436           
=======================================
  Hits         8521     8521           
  Misses       4097     4097           
  Partials      818      818           

Flag	Coverage Δ
unittests	63.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.