Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump the go_modules group across 1 directory with 2 updates #1710

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 10, 2024

Bumps the go_modules group with 2 updates in the /test/interchaintest directory: github.com/docker/distribution and github.com/docker/docker.

Updates github.com/docker/distribution from 2.8.1+incompatible to 2.8.2+incompatible

Release notes

Sourced from github.com/docker/distribution's releases.

v2.8.2

What's Changed

Full Changelog: distribution/distribution@v2.8.1...v2.8.2

v2.8.2-beta.2

What's Changed

Full Changelog: distribution/distribution@v2.8.1...v2.8.2-beta.2

v2.8.2-beta.1

NOTE: This is a pre-release that does not contain any artifacts!

What's Changed

Full Changelog: distribution/distribution@v2.8.1...v2.8.2-beta.1

Commits
  • 7c354a4 Merge pull request #3915 from distribution/2.8.2-release-notes
  • a173a9c Add v2.8.2 release notes
  • 4894d35 Merge pull request #3914 from vvoland/handle-forbidden-28
  • f067f66 Merge pull request #3783 from ndeloof/accept-encoding-28
  • 483ad69 registry/errors: Parse http forbidden as denied
  • 2b0f84d Revert "registry/client: set Accept: identity header when getting layers"
  • 320d6a1 Merge pull request #3912 from distribution/2.8.2-beta.2-release-notes
  • 5f3ca1b Add release notes for 2.8.2-beta.2 release
  • cb840f6 Merge pull request #3911 from thaJeztah/2.8_backport_fix_releaser_filenames
  • e884644 Dockerfile: fix filenames of artifacts
  • Additional commits viewable in compare view

Updates github.com/docker/docker from 24.0.9+incompatible to 25.0.6+incompatible

Release notes

Sourced from github.com/docker/docker's releases.

v25.0.6

25.0.6

For a full list of pull requests and changes in this release, refer to the relevant GitHub milestones:

Security

This release contains a fix for CVE-2024-41110 / GHSA-v23v-6jw2-98fq that impacted setups using authorization plugins (AuthZ) for access control.

Bug fixes and enhancements

  • [25.0] remove erroneous platform from image config OCI descriptor in docker save output. moby/moby#47695
  • [25.0 backport] Fix a nil dereference when getting image history for images having layers without the Created value set. moby/moby#47759
  • [25.0 backport] apparmor: Allow confined runc to kill containers. moby/moby#47830
  • [25.0 backport] Fix an issue where rapidly promoting a Swarm node after another node was demoted could cause the promoted node to fail its promotion. moby/moby#47869
  • [25.0 backport] don't depend on containerd platform.Parse to return a typed error. moby/moby#47890
  • [25.0 backport] builder/mobyexporter: Add missing nil check moby/moby#47987

Packaging updates

Full Changelog: moby/moby@v25.0.5...v25.0.6

v25.0.5

25.0.5

For a full list of pull requests and changes in this release, refer to the relevant GitHub milestones:

Security

This release contains a security fix for CVE-2024-29018, a potential data exfiltration from 'internal' networks via authoritative DNS servers.

Bug fixes and enhancements

  • CVE-2024-29018: Do not forward requests to external DNS servers for a container that is only connected to an 'internal' network. Previously, requests were forwarded if the host's DNS server was running on a loopback address, like systemd's 127.0.0.53. moby/moby#47589

  • plugin: fix mounting /etc/hosts when running in UserNS. moby/moby#47588

  • rootless: fix open /etc/docker/plugins: permission denied. moby/moby#47587

  • Fix multiple parallel docker build runs leaking disk space. moby/moby#47527

... (truncated)

Commits
  • b08a51f Merge pull request #48231 from austinvazquez/backport-vendor-otel-v0.46.1-to-...
  • d151b0f vendor: OTEL v0.46.1 / v1.21.0
  • c6ba9a5 Merge pull request #48225 from austinvazquez/backport-workflow-artifact-reten...
  • 4673a3c Merge pull request #48227 from austinvazquez/backport-backport-branch-check-t...
  • 30f8908 github/ci: Check if backport is opened against the expected branch
  • 7454d6a ci: update workflow artifacts retention
  • 65cc597 Merge commit from fork
  • b722836 Merge pull request #48199 from austinvazquez/update-containerd-binary-to-1.7.20
  • e8ecb9c update containerd binary to v1.7.20
  • e6cae1f update containerd binary to v1.7.19
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
  • @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
  • @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
  • @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
  • @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Summary by CodeRabbit

  • Chores
    • Updated various dependencies to enhance security, stability, and performance.
    • Introduced a new logging library to improve application logging capabilities.
    • Upgraded OpenTelemetry packages for potential bug fixes and feature improvements.

Bumps the go_modules group with 2 updates in the /test/interchaintest directory: [github.com/docker/distribution](https://github.com/docker/distribution) and [github.com/docker/docker](https://github.com/docker/docker).


Updates `github.com/docker/distribution` from 2.8.1+incompatible to 2.8.2+incompatible
- [Release notes](https://github.com/docker/distribution/releases)
- [Commits](distribution/distribution@v2.8.1...v2.8.2)

Updates `github.com/docker/docker` from 24.0.9+incompatible to 25.0.6+incompatible
- [Release notes](https://github.com/docker/docker/releases)
- [Commits](moby/moby@v24.0.9...v25.0.6)

---
updated-dependencies:
- dependency-name: github.com/docker/distribution
  dependency-type: indirect
  dependency-group: go_modules
- dependency-name: github.com/docker/docker
  dependency-type: indirect
  dependency-group: go_modules
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot requested review from joe-bowman and faddat as code owners August 10, 2024 04:43
@dependabot dependabot bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Aug 10, 2024
@dependabot dependabot bot requested a review from minhngoc274 as a code owner August 10, 2024 04:43
Copy link

vercel bot commented Aug 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
quicksilver ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 10, 2024 5:12am

Copy link
Contributor

coderabbitai bot commented Aug 10, 2024

Walkthrough

The recent updates to the go.mod file enhance the Go project's dependency management by removing unneeded packages, introducing new logging capabilities, and upgrading several core libraries. Notably, OpenTelemetry dependencies were updated to include new features and improvements, while Google API dependencies were also refreshed. These changes aim to enhance stability, performance, and maintainability of the application.

Changes

Files Change Summary
test/interchaintest/go.mod Removed github.com/cenkalti/backoff/v4 v4.3.0, added github.com/containerd/log v0.1.0, updated OpenTelemetry dependencies from v1.27.0 to v1.28.0, added go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp v1.28.0, updated google.golang.org/genproto dependencies to newer versions.

Poem

🐰 In the meadow, changes bloom,
Old dependencies fade, make room!
With logs anew and tracing bright,
Our code’s now soaring, full of light.
A hop, a skip, to better days,
Let’s celebrate in joyful ways! 🎉


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 9af89f5 and b5c3d5e.

Files ignored due to path filters (1)
  • test/interchaintest/go.sum is excluded by !**/*.sum
Files selected for processing (1)
  • test/interchaintest/go.mod (5 hunks)
Additional comments not posted (5)
test/interchaintest/go.mod (5)

191-195: Verify compatibility of OpenTelemetry updates.

The OpenTelemetry dependencies have been updated to v1.28.0. Ensure that these updates are compatible with existing instrumentation and do not introduce any issues.

Verification successful

No compatibility issues found with OpenTelemetry update.

The update to OpenTelemetry dependencies to v1.28.0 appears to be safe, as there are no direct usages of OpenTelemetry in the Go codebase that could be affected by this change.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify compatibility of OpenTelemetry updates with existing instrumentation.

# Test: Search for `otel` usage in the codebase. Expect: No compatibility issues with the update.
rg --type go 'otel'

Length of output: 106


192-192: Verify configuration of new OpenTelemetry HTTP exporter.

The addition of go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp v1.28.0 suggests enhanced tracing capabilities. Ensure it is properly configured and integrated.


210-211: Verify compatibility of Google API updates.

The updates to google.golang.org/genproto/googleapis/api and google.golang.org/genproto/googleapis/rpc may affect API interactions. Ensure compatibility with existing code.


50-50: Verify compatibility of new logging dependency.

The addition of github.com/containerd/log v0.1.0 suggests a change in logging strategy. Ensure it integrates well with existing logging systems and doesn't introduce conflicts.

Verification successful

No direct usage of github.com/containerd/log found.

The github.com/containerd/log dependency is marked as indirect in the go.mod file, and there are no direct references to it in the codebase. This suggests that it might be a transitive dependency or not actively used in the code. Ensure that any indirect dependencies are necessary and do not introduce unnecessary bloat.

  • Verify if this indirect dependency is required by checking its usage in any transitive dependencies.
Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify integration of `github.com/containerd/log` with existing logging systems.

# Test: Search for usage of `containerd/log` in the codebase. Expect: Proper integration without conflicts.
rg --type go 'containerd/log'

Length of output: 29


Script:

#!/bin/bash
# Check for the presence of `github.com/containerd/log` in the go.mod file and its indirect status.
rg 'github.com/containerd/log' test/interchaintest/go.mod

# Search for any indirect usage of `github.com/containerd/log` in the codebase.
rg 'log' --type go -A 5

Length of output: 113696


70-70: Ensure handling of potential breaking changes in Docker update.

The update to github.com/docker/docker v25.0.6+incompatible addresses a security vulnerability. Verify that any breaking changes in this version are managed appropriately.

Copy link

codecov bot commented Aug 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.90%. Comparing base (9af89f5) to head (b5c3d5e).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1710   +/-   ##
=======================================
  Coverage   63.90%   63.90%           
=======================================
  Files         196      196           
  Lines       13798    13798           
=======================================
  Hits         8818     8818           
  Misses       4126     4126           
  Partials      854      854           
Flag Coverage Δ
unittests 63.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@faddat faddat enabled auto-merge (squash) August 10, 2024 05:24
@faddat faddat merged commit efda503 into main Aug 10, 2024
19 checks passed
@dependabot dependabot bot deleted the dependabot/go_modules/test/interchaintest/go_modules-004f87fb2b branch August 10, 2024 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant