Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

epochs: increase test coverage to 90+% #1549

Merged
merged 2 commits into from
May 2, 2024

Conversation

pysel
Copy link
Contributor

@pysel pysel commented May 2, 2024

1. Summary

Fixes # (issue)

2.Type of change

Increases test coverage of epochs module to 90.6%

Copy link

vercel bot commented May 2, 2024

@pysel is attempting to deploy a commit to the quicksilver Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

coderabbitai bot commented May 2, 2024

Walkthrough

The updates mainly enhance the keeper module in the Go coverage report, focusing on epoch management functionalities. Changes include new methods for beginning and ending epochs, querying epoch information, and managing epoch hooks. These alterations aim to improve module interaction and data handling, ensuring better control and flexibility in epoch operations.

Changes

Files Change Summary
cover.html Added coverage report for the keeper module with enhanced HTML styling and navigation.
x/epochs/keeper/... Updated methods related to epoch lifecycle management, including starting, ending, and querying epochs. Added functions to manage epoch hooks and logging.
x/epochs/keeper/grpc_query_test.go Added test for querying the current epoch status.

🐇✨
In the code's garden, changes bloom,
Epochs dance in freshened room.
Keeper's tools, now sharp and bright,
Guide the data through the night.
With every line, the future's spun—
A coder's work is never done. 🌟
🐇💻


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Out of diff range and nitpick comments (1)
x/epochs/keeper/grpc_query_test.go (1)

Line range hint 1-40: Consider adding a test case for handling invalid requests in TestQueryEpochInfos.

Would you like me to help by adding a test case for this scenario?

Copy link

codecov bot commented May 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.97%. Comparing base (9b4b2b9) to head (df3c182).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1549      +/-   ##
==========================================
+ Coverage   62.91%   62.97%   +0.05%     
==========================================
  Files         194      194              
  Lines       13632    13632              
==========================================
+ Hits         8577     8585       +8     
+ Misses       4233     4225       -8     
  Partials      822      822              
Flag Coverage Δ
unittests 62.97% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

@joe-bowman joe-bowman enabled auto-merge (squash) May 2, 2024 10:03
Copy link
Contributor

@joe-bowman joe-bowman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@joe-bowman joe-bowman merged commit fe395c5 into quicksilver-zone:main May 2, 2024
19 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants