Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compress images; ensure svg exists for all denoms #1516

Merged
merged 3 commits into from
Apr 30, 2024
Merged

Conversation

joe-bowman
Copy link
Contributor

@joe-bowman joe-bowman commented Apr 29, 2024

Ensure SVG images exist for all qAssets
Lossless compression of SVGs and PNGs
Remove legacy chainInfo

Summary by CodeRabbit

  • Bug Fixes
    • Updated the logo path for the 'OSMO' network to ensure correct display.
    • Improved calculation logic for displaying the redemption amount in the AssetCard component.

@joe-bowman joe-bowman requested a review from chalabi2 as a code owner April 29, 2024 11:04
Copy link

vercel bot commented Apr 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
quicksilver ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 29, 2024 11:46am

Copy link
Contributor

coderabbitai bot commented Apr 29, 2024

Walkthrough

The recent update involves refining the user interface with impactful changes. The 'OSMO' network's logo path was updated for consistency, and the redemption amount calculation logic in the AssetCard component was enhanced for accuracy.

Changes

File Path Change Summary
web-ui/test/Staking.test.tsx Updated the logo path for the 'OSMO' network.
web-ui/components/Assets/assetsGrid.tsx Refined redemption amount calculation logic.
web-ui/.env Updated NEXT_PUBLIC_DYDX_CHAIN_ID to NEXT_PUBLIC_SAGA_CHAIN_ID with value ssc-1.

🐰✨
In the realm of bits and bytes,
A rabbit dances with delights.
Logo paths shift, calculations refine,
Code sings a tune, a magical line.
OSMO shines, assets align,
In the web UI, a touch divine! 🌟
🐰✨


Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between bc3fdf9 and 5d0c963.
Files selected for processing (1)
  • web-ui/.env (1 hunks)
Additional comments not posted (1)
web-ui/.env (1)

34-34: Verify the update of NEXT_PUBLIC_DYDX_CHAIN_ID to NEXT_PUBLIC_SAGA_CHAIN_ID with the value ssc-1.

Please ensure that this change is reflected across all relevant parts of the project and that no references to the old chain ID remain unless intended.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.97%. Comparing base (c5d75d8) to head (5d0c963).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1516   +/-   ##
=======================================
  Coverage   62.97%   62.97%           
=======================================
  Files         192      192           
  Lines       13495    13495           
=======================================
  Hits         8499     8499           
  Misses       4181     4181           
  Partials      815      815           
Flag Coverage Δ
unittests 62.97% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@joe-bowman
Copy link
Contributor Author

This pull request has been deployed to Vercel.

Latest commit: 5d0c963
✅ Preview: https://pr-1516.app-dev.quicksilver.zone
🔍 Inspect: https://vercel.com/quicksilver/quicksilver/EMAk1Gh9AUckMjei6JR63PKyyAL6

View Workflow Logs

@joe-bowman joe-bowman merged commit 7f095c3 into main Apr 30, 2024
26 checks passed
@joe-bowman joe-bowman deleted the web-ui-compress branch May 8, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant