remove dust_threshold from UpdateZoneProposal; cast dust_threshold to…

[joe-bowman]

remove dust_threshold from UpdateZoneProposal; cast dust_threshold to int on RegisterZoneProposals

1. Summary

Fixes #1496

Dust threshold field should not exist on updateZoneProposal and should be a math.Int on registerZoneProposal

Summary by CodeRabbit

• Refactor
  • Simplified the handling of the DustThreshold parameter across various proposal functionalities.
• Bug Fixes
  • Updated the DustThreshold field from a string to an integer to enhance precision and reliability.
• Documentation
  • Removed unnecessary annotations to streamline proposal message structures.
• New Features
  • Added the ability to update the DustThreshold field in zone management proposals.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
quicksilver	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 26, 2024 9:10am

[coderabbitai]

Walkthrough

The modifications primarily focus on managing the DustThreshold field across various structures and functions within the interchainstaking module. The changes include removing outdated annotations, adjusting data types, and enhancing the configurability of DustThreshold to better align with different blockchain environments or requirements.

Changes

File Path	Change Summary
proto/quicksilver/interchainstaking/v1/proposals.proto	Removed (gogoproto.moretags) annotations from multiple fields in several message types.
x/interchainstaking/client/cli/tx.go, x/interchainstaking/keeper/proposal_handler.go	Adjusted handling and creation of proposals related to DustThreshold.
x/interchainstaking/keeper/keeper_test.go, x/interchainstaking/types/proposals.go, x/interchainstaking/types/proposals_test.go	Updated DustThreshold from string to math.Int, added imports, and adjusted related validation logic.

Assessment against linked issues

Objective	Addressed	Explanation
Make the dust threshold value configurable per zone (#1100)	✅
Dust Threshold not set correctly in UpdateZoneProposal (#1496)	✅	The handling of DustThreshold within UpdateZoneProposal has been corrected as described.

Possibly related issues

• Make dustThreshold configurable per chain #1100: This issue is directly addressed by making DustThreshold configurable per zone, which aligns with the changes in this PR.

Poem

🐰 "In the land of code and byte,"
"Where data streams both day and night,"
"A rabbit hopped with all its might,"
"To tweak the threshold just right."
"Now each zone can set its own,"
"A dust limit, finely honed!" 🌟
"- CodeRabbit" 🎩🐇

---

Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 8312db2 and 33c4c68.

Files selected for processing (2)

• x/interchainstaking/types/proposals.go (4 hunks)
• x/interchainstaking/types/proposals_test.go (11 hunks)

Files skipped from review as they are similar to previous changes (2)

• x/interchainstaking/types/proposals.go
• x/interchainstaking/types/proposals_test.go

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

Attention: Patch coverage is 31.25000% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 63.13%. Comparing base (4d087cc) to head (da5f1cc).
Report is 2 commits behind head on main.

❗ Current head da5f1cc differs from pull request most recent head 33c4c68. Consider uploading reports for the commit 33c4c68 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1504      +/-   ##
==========================================
- Coverage   63.13%   63.13%   -0.01%     
==========================================
  Files         192      192              
  Lines       13458    13464       +6     
==========================================
+ Hits         8497     8500       +3     
- Misses       4151     4154       +3     
  Partials      810      810              

Flag	Coverage Δ
unittests	63.13% <31.25%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
x/interchainstaking/client/cli/tx.go	10.77% <0.00%> (+0.06%)	⬆️
x/interchainstaking/types/proposals.go	38.14% <50.00%> (+1.68%)	⬆️
x/interchainstaking/keeper/proposal_handler.go	64.77% <16.66%> (-1.70%)	⬇️

[joe-bowman]

This pull request has been deployed to Vercel.

Latest commit:	da5f1cc
✅ Preview:	https://pr-1504.app-dev.quicksilver.zone
🔍 Inspect:	https://vercel.com/quicksilver/quicksilver/E7s4rq5CBsGNUfCu24LBcwurE8A7

View Workflow Logs

[minhngoc274]

LGTM