Use local channel in RTS logic

[joe-bowman]

1. Summary

Fixes #1497

Change channel and port to use the local end of the connection, not the counterparty when sending for RTS.

Summary by CodeRabbit

• Bug Fixes
  • Updated the assignment of source channel and port identifiers to correctly reflect the current channel properties, enhancing accuracy in data handling.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
quicksilver	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 25, 2024 9:45pm

[coderabbitai]

Walkthrough

The update involves altering how srcChannel and srcPort are assigned in the ReturnToSender logic. Previously using counterparty channel and port IDs, the code now correctly uses local channel and port IDs to ensure packets are sent back through the appropriate channel, addressing issues with failed transmissions.

Changes

File Path	Change Summary
x/interchainstaking/keeper/receipt.go	Updated srcChannel and srcPort assignments from counterparty IDs to local IDs within a loop.

Assessment against linked issues

Objective	Addressed	Explanation
ReturnToSender logic sends tokens over Local Channel (#1497)	✅

🐰🌟
A tiny tweak in the code, a giant leap for the flow,
Through local gates, our packets now go.
A rabbit hops along the digital plain,
Ensuring no token ever goes in vain.
Hooray for changes, small but mighty! 🚀🎉
🐰🌟

---

Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 736ecbc and db018bd.

Files selected for processing (1)

• x/interchainstaking/keeper/receipt.go (1 hunks)

Additional comments not posted (1)

x/interchainstaking/keeper/receipt.go (1)

144-145: Correctly updated srcChannel and srcPort to use local channel details.

This change ensures that the ReturnToSender logic functions correctly by utilizing the appropriate local connection details for packet transmission in the interchain staking module.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[joe-bowman]

This pull request has been deployed to Vercel.

Latest commit:	db018bd
✅ Preview:	https://pr-1498.app-dev.quicksilver.zone
🔍 Inspect:	https://vercel.com/quicksilver/quicksilver/2Q4yGUAxcUm6hkTHD9T1NNydWTyF

View Workflow Logs

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.13%. Comparing base (736ecbc) to head (db018bd).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1498   +/-   ##
=======================================
  Coverage   63.13%   63.13%           
=======================================
  Files         192      192           
  Lines       13458    13458           
=======================================
  Hits         8497     8497           
  Misses       4151     4151           
  Partials      810      810           

Flag	Coverage Δ
unittests	63.13% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
x/interchainstaking/keeper/receipt.go	77.91% <100.00%> (ø)

[minhngoc274]

LGTM

[odeke-em]

Ideally we should write a test to lock this behavior in and prevent future regressions.