refactor: remove token factory #1490

minhngoc274 · 2024-04-24T17:06:55Z

1. Summary

Close #1474

2.Type of change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

3. Implementation details

4. How to test/use

5. Checklist

Does the Readme need to be updated?

6. Limitations (optional)

7. Future Work (optional)

Summary by CodeRabbit

New Features
- Added GetScopedICAControllerKeeper to enhance interface implementation.
- Introduced new upgrade handler for better version management.
Refactor
- Updated numerous modules to ibc-go version 6 for improved integration.
- Removed all references and configurations related to wasm to streamline app functionalities.
- Simplified initializations and settings across various modules for better performance and maintainability.
Bug Fixes
- Adjusted import paths and references to ensure compatibility with updated modules.
Chores
- Updated BUF_VERSION for enhanced Protobuf handling.
- Removed outdated code and comments to maintain code cleanliness.

vercel · 2024-04-24T17:07:01Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
quicksilver	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 25, 2024 4:29pm

coderabbitai · 2024-04-24T17:07:26Z

Walkthrough

The updates involve transitioning away from the wasm module, upgrading to ibc-go version 6, and adjusting import paths, configurations, and initializations. The Makefile also reflects changes with an updated BUF_VERSION for Protobuf, aligning dependencies and configurations.

Changes

Files	Change Summary
Dockerfile	Updated base images, commented out library download section.
Makefile	Updated BUF_VERSION, commented out `proto-setup` target.
app/ante.go	Updated imports, removed `wasm` references, simplified configurations.
app/app.go	Updated imports, removed `wasm` configurations, simplified initialization.
app/config.go	Removed `wasm` references, adjusted initialization parameters.
app/genesis.go	Removed imports related to `wasm` and `wasmtypes`.
app/keepers/keepers.go	Updated import paths, refactored and removed keepers.
app/modules.go	Updated import paths, removed references to `tokenfactory` and `wasm`.
app/test_helpers.go	Updated import path, removed references to `wasm` configurations.
app/upgrades.go	Updated imports, introduced new upgrade handler.
app/upgrades/types.go	Added constant `V010600rc1UpgradeName`.
app/upgrades_test.go	Updated imports for `ibc-go` modules.
cmd/config/config.go	Removed `SetWasmConfig` function.
cmd/quicksilverd/root.go	Removed `wasm` references, configurations, and metrics.
icq-relayer/cmd/modules.go	Updated imports related to IBC modules.
icq-relayer/pkg/runner/run.go	Updated import paths for packages.
test/..., utils/...	Updated import paths, removed `wasm` references.
x/..., x/...	Updated import paths, modified functions and capabilities.

🐇✨
In the code's burrow, deep and wide,
Changes spring forth with a mighty stride.
No more wasm in the garden grows,
Onward with IBC, the river flows.
Rejoice in updates, oh merry band,
For new versions shape the land!
🌟📜

Possibly related issues

Remove tokenfactory #1474: Removing tokenfactory aligns with the removal of old CosmWasm, streamlining dependencies for future updates.

Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between bc313d9 and a7edf18.

Files selected for processing (1)

app/keepers/keepers.go (4 hunks)

Files skipped from review as they are similar to previous changes (1)

app/keepers/keepers.go

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

minhngoc274 · 2024-04-25T03:26:10Z

we should merge this one #1421 first

codecov · 2024-04-25T03:38:01Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.13%. Comparing base (f7cef8f) to head (a7edf18).
Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1490      +/-   ##
==========================================
+ Coverage   61.93%   63.13%   +1.19%     
==========================================
  Files         218      192      -26     
  Lines       14729    13458    -1271     
==========================================
- Hits         9123     8497     -626     
+ Misses       4743     4151     -592     
+ Partials      863      810      -53

Flag	Coverage Δ
unittests	`63.13% <100.00%> (+1.19%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
app/keepers/keepers.go	`98.10% <ø> (-0.22%)`	⬇️
app/keepers/keys.go	`91.30% <ø> (-0.37%)`	⬇️
app/modules.go	`100.00% <ø> (ø)`
x/interchainstaking/keeper/receipt.go	`77.91% <100.00%> (+1.47%)`	⬆️

... and 2 files with indirect coverage changes

joe-bowman · 2024-04-25T16:28:10Z

Rebased on main post ibc-v6 merge, and fixed a couple of bugs.

joe-bowman · 2024-04-25T16:32:57Z

This pull request has been deployed to Vercel.

Latest commit:	`a7edf18`
✅ Preview:	https://pr-1490.app-dev.quicksilver.zone
🔍 Inspect:	https://vercel.com/quicksilver/quicksilver/88uMjjC56jRA4PYUG3C1BpHH6wdS

View Workflow Logs

joe-bowman

lgtm

vercel bot temporarily deployed to Preview April 24, 2024 17:07 Inactive

joe-bowman temporarily deployed to Preview April 24, 2024 17:09 Inactive

joe-bowman added the deployed label Apr 24, 2024

minhngoc274 marked this pull request as ready for review April 25, 2024 03:24

minhngoc274 requested review from joe-bowman, faddat and tuantran1702 as code owners April 25, 2024 03:24

minhngoc274 changed the base branch from faddat/update-ibc-v6 to main April 25, 2024 03:24

vercel bot temporarily deployed to Preview April 25, 2024 03:26 Inactive

joe-bowman temporarily deployed to Preview April 25, 2024 03:27 Inactive

faddat and others added 13 commits April 25, 2024 14:27

update to ibc v6

d49568c

fix test and bump pfm v6

0a5fa6a

remove wasmd and cosmwasm and delete store key

1b2084c

add deployment

4047f8c

update to ibc v6

1adb7ca

update to ibc v6

0b90818

fix test and bump pfm v6

c629300

remove wasmd and cosmwasm and delete store key

8586cf9

add deployment

8733b47

linting

b9ebf48

refactor: remove token factory

00d0690

remove tokenfactory proto

01749c6

fix channel capability issue, and remove wasm from Dockerfile

bc313d9

joe-bowman force-pushed the ngoc/remove-tokenfactory branch from bdfebce to bc313d9 Compare April 25, 2024 16:25

lint

a7edf18

joe-bowman temporarily deployed to Preview April 25, 2024 16:27 Inactive

joe-bowman temporarily deployed to Preview April 25, 2024 16:30 Inactive

joe-bowman approved these changes Apr 25, 2024

View reviewed changes

joe-bowman merged commit 736ecbc into main Apr 25, 2024
26 checks passed

joe-bowman deleted the ngoc/remove-tokenfactory branch April 25, 2024 18:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: remove token factory #1490

refactor: remove token factory #1490

minhngoc274 commented Apr 24, 2024 •

edited by coderabbitai bot

Loading

vercel bot commented Apr 24, 2024 •

edited

Loading

coderabbitai bot commented Apr 24, 2024 •

edited

Loading

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

Documentation and Community

minhngoc274 commented Apr 25, 2024

codecov bot commented Apr 25, 2024 •

edited

Loading

joe-bowman commented Apr 25, 2024

joe-bowman commented Apr 25, 2024

joe-bowman left a comment

refactor: remove token factory #1490

refactor: remove token factory #1490

Conversation

minhngoc274 commented Apr 24, 2024 • edited by coderabbitai bot Loading

1. Summary

2.Type of change

3. Implementation details

4. How to test/use

5. Checklist

6. Limitations (optional)

7. Future Work (optional)

Summary by CodeRabbit

vercel bot commented Apr 24, 2024 • edited Loading

coderabbitai bot commented Apr 24, 2024 • edited Loading

Walkthrough

Changes

Possibly related issues

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

Documentation and Community

minhngoc274 commented Apr 25, 2024

codecov bot commented Apr 25, 2024 • edited Loading

Codecov Report

joe-bowman commented Apr 25, 2024

joe-bowman commented Apr 25, 2024

joe-bowman left a comment

Choose a reason for hiding this comment

minhngoc274 commented Apr 24, 2024 •

edited by coderabbitai bot

Loading

vercel bot commented Apr 24, 2024 •

edited

Loading

coderabbitai bot commented Apr 24, 2024 •

edited

Loading

CodeRabbit Configration File (`.coderabbit.yaml`)

codecov bot commented Apr 25, 2024 •

edited

Loading