Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

icq-relayer v0.11 #1451

Merged
merged 4 commits into from
Apr 18, 2024
Merged

icq-relayer v0.11 #1451

merged 4 commits into from
Apr 18, 2024

Conversation

joe-bowman
Copy link
Contributor

@joe-bowman joe-bowman commented Apr 17, 2024

1. Summary

  • Add support for cosmos-sdk v0.50 GetTxsEvents request type
  • Make metrics bind port configurable
  • Set default config file to be mainnet ready
  • Reduce log verbosity
  • Add max_msgs_per_tx congig variable
  • Dynamic MsgPerTx: Make the MsgPerTx value reduce on failed requests, and slowly return to MaxMsgsPerTx over time on success

Summary by CodeRabbit

  • New Features

    • Introduced mainnet-compatible configuration generation on first run.
    • Added support for cosmos-sdk v0.50 GetTxsEvents request type.
    • Configurable metrics bind port now available.
    • Default mainnet-ready configuration file included.
  • Enhancements

    • Updated configuration file structure and functionality.
    • Refined command functionality and descriptions for better clarity.
    • Adjusted dynamic message batching based on request success.
  • Bug Fixes

    • Improved error handling in the Run function to provide clearer error messages.
  • Documentation

    • Updated README with new configuration details and removed outdated YAML format information.
    • Enhanced API documentation clarity and removed redundant comments.
  • Refactor

    • Removed unused debug flags and parameters across various functions and files.
    • Updated import paths and adjusted configuration settings for streamlined operations.
  • Style

    • Reduced log verbosity for cleaner output.

Joe Bowman added 2 commits April 17, 2024 10:24
… log verbosity; make default config appropriate for direct use on mainnet
Copy link

vercel bot commented Apr 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
quicksilver ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 17, 2024 1:58pm

Copy link
Contributor

coderabbitai bot commented Apr 17, 2024

Walkthrough

The updates encompass refining the icq-relayer for Quicksilver interchain queries, improving error handling, configuration, and logging. Notable enhancements include support for cosmos-sdk v0.50, dynamic transaction message batching, and simplified configuration processes. These changes aim to streamline setup, enhance operational efficiency, and prepare the relayer for mainnet deployment.

Changes

File Path Changes
icq-relayer/pkg/runner/run.go Updated version constant, adjusted handling of maximum transaction messages, introduced LastReduced variable, modified error logging behavior, refined logic for message submission and batching, handled body size errors during message submission.

🐰✨📜
Oh hark! The code doth change, refine,
With swifter logs and lines align.
From cosmos' reach to queries deep,
The relayer's path, robust and steep.
A hop, a skip, a digital leap! 🚀🌌
🐰✨📜


Recent Review Details

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 7bf97d2 and 6b8781c.
Files selected for processing (1)
  • icq-relayer/pkg/runner/run.go (23 hunks)
Files skipped from review as they are similar to previous changes (1)
  • icq-relayer/pkg/runner/run.go

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Apr 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.58%. Comparing base (3336972) to head (6b8781c).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1451   +/-   ##
=======================================
  Coverage   63.58%   63.58%           
=======================================
  Files         171      171           
  Lines       11681    11681           
=======================================
  Hits         7427     7427           
  Misses       3504     3504           
  Partials      750      750           
Flag Coverage Δ
unittests 63.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

icq-relayer/pkg/runner/run.go Dismissed Show dismissed Hide dismissed
icq-relayer/pkg/runner/run.go Dismissed Show dismissed Hide dismissed
icq-relayer/pkg/runner/run.go Dismissed Show dismissed Hide dismissed
faddat
faddat previously approved these changes Apr 17, 2024
@joe-bowman
Copy link
Contributor Author

This pull request has been deployed to Vercel.

Latest commit: 6b8781c
✅ Preview: https://pr-1451.app-dev.quicksilver.zone
🔍 Inspect: https://vercel.com/quicksilver/quicksilver/BdHGhD4QFhRkmW3dBaW7sVP3b4yv

View Workflow Logs

@faddat faddat merged commit 7dfe921 into main Apr 18, 2024
26 checks passed
@joe-bowman joe-bowman deleted the icq-v011 branch May 8, 2024 13:36
@joe-bowman joe-bowman restored the icq-v011 branch May 8, 2024 13:36
@joe-bowman joe-bowman deleted the icq-v011 branch May 8, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants