upgrade pfm to v5.2.2 #1356

joe-bowman · 2024-03-27T12:03:28Z

1. Summary

Fixes #1328

Upgrade packet forwarding middleware to v5.2.2

2.Type of change

dependency upgrade

3. Implementation details

Upgrade packet forwarding middleware to v5.2.2

Summary by CodeRabbit

Refactor
- Updated import paths for packet forwarding middleware to align with the new project structure under cosmos/ibc-apps.

vercel · 2024-03-27T12:03:34Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
quicksilver	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Mar 27, 2024 0:30am

coderabbitai · 2024-03-27T12:03:35Z

Walkthrough

The changes involve a strategic update in import paths for packet forwarding middleware, transitioning from strangelove-ventures to cosmos/ibc-apps. This likely signifies a reorganization or enhancement of middleware packages, aligning with the upgrade to PFM version 5.2.2.

Changes

File Path	Change Summary
`app/keepers/keepers.go`, `app/modules.go`	Updated import paths for packet forwarding middleware from `strangelove-ventures` to `cosmos/ibc-apps`.
`app/modules.go`	Changed import paths for `packetforward` and `packetforwardtypes` packages to `cosmos/ibc-apps`.

Assessment against linked issues

Objective	Addressed	Explanation
Upgrade PFM to 5.2.2 (#1328)	❌	The PR documentation mentions import path updates but lacks explicit confirmation of the upgrade to version 5.2.2.

🐰✨

In the realm of code, where packets roam free,
A rabbit hopped forth, changing paths with glee.
From strangelove realms to cosmos skies,
An upgrade unfolds, beneath the digital eyes.
🚀 To 5.2.2, we aim to leap,
In this digital burrow, where the bytes do creep.
🌌✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit-tests for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit tests for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit tests.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
The JSON schema for the configuration file is available here.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

coderabbitai

Review Status

Actionable comments generated: 2

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between ee84086 and d0ff954.

Files ignored due to path filters (2)

go.mod is excluded by: !**/*.mod
go.sum is excluded by: !**/*.sum

Files selected for processing (4)

app/keepers/keepers.go (1 hunks)
app/keepers/keys.go (1 hunks)
app/modules.go (1 hunks)
app/upgrades.go (1 hunks)

Additional comments: 5

app/upgrades.go (1)

6-6: The updated import path for packetforwardtypes aligns with the PR objectives and is correctly implemented.

app/keepers/keys.go (1)

5-5: The updated import path for packetforwardtypes aligns with the PR objectives and is correctly implemented.

app/modules.go (1)

6-6: The updated import path for packetforwardtypes aligns with the PR objectives and is correctly implemented.

app/keepers/keepers.go (2)

6-6: The updated import path for packetforwardkeeper aligns with the PR objectives and is correctly implemented.

7-7: The updated import path for packetforwardtypes aligns with the PR objectives and is correctly implemented.

coderabbitai · 2024-03-27T12:09:12Z

app/modules.go

@@ -2,8 +2,8 @@

 import (
 	"github.com/CosmWasm/wasmd/x/wasm"
-	packetforward "github.com/strangelove-ventures/packet-forward-middleware/v5/router"
-	packetforwardtypes "github.com/strangelove-ventures/packet-forward-middleware/v5/router/types"
+	packetforward "github.com/cosmos/ibc-apps/middleware/packet-forward-middleware/v5/packetforward"


The import alias for packetforward is redundant. Since the package name matches the alias, you can remove the alias for clarity.

- packetforward "github.com/cosmos/ibc-apps/middleware/packet-forward-middleware/v5/packetforward" + "github.com/cosmos/ibc-apps/middleware/packet-forward-middleware/v5/packetforward"

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change

packetforward "github.com/cosmos/ibc-apps/middleware/packet-forward-middleware/v5/packetforward"

"github.com/cosmos/ibc-apps/middleware/packet-forward-middleware/v5/packetforward"

coderabbitai · 2024-03-27T12:09:12Z

app/keepers/keepers.go

-	packetforward "github.com/strangelove-ventures/packet-forward-middleware/v5/router"
-	packetforwardkeeper "github.com/strangelove-ventures/packet-forward-middleware/v5/router/keeper"
-	packetforwardtypes "github.com/strangelove-ventures/packet-forward-middleware/v5/router/types"
+	packetforward "github.com/cosmos/ibc-apps/middleware/packet-forward-middleware/v5/packetforward"


The import alias for packetforward is redundant. Since the package name matches the alias, you can remove the alias for clarity.

- packetforward "github.com/cosmos/ibc-apps/middleware/packet-forward-middleware/v5/packetforward" + "github.com/cosmos/ibc-apps/middleware/packet-forward-middleware/v5/packetforward"

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change

packetforward "github.com/cosmos/ibc-apps/middleware/packet-forward-middleware/v5/packetforward"

"github.com/cosmos/ibc-apps/middleware/packet-forward-middleware/v5/packetforward"

codecov · 2024-03-27T12:16:44Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.51%. Comparing base (ee84086) to head (96d489f).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1356   +/-   ##
=======================================
  Coverage   63.51%   63.51%           
=======================================
  Files         171      171           
  Lines       11636    11636           
=======================================
  Hits         7391     7391           
  Misses       3500     3500           
  Partials      745      745

Flag	Coverage Δ
unittests	`63.51% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
app/modules.go	`100.00% <ø> (ø)`
app/upgrades.go	`62.50% <ø> (ø)`

coderabbitai

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between d0ff954 and 96d489f.

Files selected for processing (2)

app/keepers/keepers.go (1 hunks)
app/modules.go (1 hunks)

Files skipped from review as they are similar to previous changes (2)

app/keepers/keepers.go
app/modules.go

joe-bowman · 2024-03-27T12:33:11Z

This pull request has been deployed to Vercel.

Latest commit:	`96d489f`
✅ Preview:	https://pr-1356.app-dev.quicksilver.zone
🔍 Inspect:	https://vercel.com/quicksilver/quicksilver/F4Z2Ri5H2rQqhBfQZUccVmgKsATE

View Workflow Logs

tuantran1702

LGTM

joe-bowman · 2024-03-27T17:21:52Z

LGTM

When you lgtm, can you add an 'approve' review, rather than just comment, else I can't merge the PR 🙏🏻

upgrade pfm to v5.2.2

d0ff954

joe-bowman requested review from faddat, minhngoc274 and tuantran1702 as code owners March 27, 2024 12:03

joe-bowman temporarily deployed to Preview March 27, 2024 12:06 Inactive

joe-bowman added the deployed label Mar 27, 2024

coderabbitai bot reviewed Mar 27, 2024

View reviewed changes

lint

96d489f

vercel bot temporarily deployed to Preview March 27, 2024 12:30 Inactive

joe-bowman temporarily deployed to Preview March 27, 2024 12:31 Inactive

coderabbitai bot reviewed Mar 27, 2024

View reviewed changes

tuantran1702 reviewed Mar 27, 2024

View reviewed changes

joe-bowman merged commit 98584e8 into main Mar 27, 2024
26 checks passed

joe-bowman deleted the pfm-522 branch March 27, 2024 17:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

upgrade pfm to v5.2.2 #1356

upgrade pfm to v5.2.2 #1356

joe-bowman commented Mar 27, 2024 •

edited by coderabbitai bot

Loading

vercel bot commented Mar 27, 2024 •

edited

Loading

coderabbitai bot commented Mar 27, 2024 •

edited

Loading

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

CodeRabbit Discord Community

coderabbitai bot left a comment

coderabbitai bot Mar 27, 2024

coderabbitai bot Mar 27, 2024

codecov bot commented Mar 27, 2024 •

edited

Loading

coderabbitai bot left a comment

joe-bowman commented Mar 27, 2024

tuantran1702 left a comment

joe-bowman commented Mar 27, 2024

	packetforward "github.com/cosmos/ibc-apps/middleware/packet-forward-middleware/v5/packetforward"
	"github.com/cosmos/ibc-apps/middleware/packet-forward-middleware/v5/packetforward"

upgrade pfm to v5.2.2 #1356

upgrade pfm to v5.2.2 #1356

Conversation

joe-bowman commented Mar 27, 2024 • edited by coderabbitai bot Loading

1. Summary

2.Type of change

3. Implementation details

Summary by CodeRabbit

vercel bot commented Mar 27, 2024 • edited Loading

coderabbitai bot commented Mar 27, 2024 • edited Loading

Walkthrough

Changes

Assessment against linked issues

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

CodeRabbit Discord Community

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot Mar 27, 2024

Choose a reason for hiding this comment

coderabbitai bot Mar 27, 2024

Choose a reason for hiding this comment

codecov bot commented Mar 27, 2024 • edited Loading

Codecov Report

coderabbitai bot left a comment

Choose a reason for hiding this comment

joe-bowman commented Mar 27, 2024

tuantran1702 left a comment

Choose a reason for hiding this comment

joe-bowman commented Mar 27, 2024

joe-bowman commented Mar 27, 2024 •

edited by coderabbitai bot

Loading

vercel bot commented Mar 27, 2024 •

edited

Loading

coderabbitai bot commented Mar 27, 2024 •

edited

Loading

CodeRabbit Configration File (`.coderabbit.yaml`)

codecov bot commented Mar 27, 2024 •

edited

Loading