update v1.6.0 upgrade handler add zone by local denom

[minhngoc274]

1. Summary

Mentioned in #1198

2.Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

3. Implementation details

4. How to test/use

5. Checklist

• Does the Readme need to be updated?

6. Limitations (optional)

7. Future Work (optional)

Summary by CodeRabbit

• New Features
  • Enhanced the upgrade handler to support local denomination zone mappings for improved interchain staking management.

[coderabbitai]

Walkthrough

This update introduces a new functionality in the V010600UpgradeHandler function, focusing on iterating over zones to establish local denomination zone mappings in the InterchainstakingKeeper. Additionally, the accompanying test, TestV010600UpgradeHandler, has been enhanced with validation checks to ensure the accurate retrieval of these mappings. This enhancement aims to refine the process of managing interchain staking denominations.

Changes

Files	Summary
app/upgrades/upgrades.go app/upgrades_test.go	Added logic for setting local denom zone mappings in InterchainstakingKeeper and validation checks in tests.

"In the realm of code, where logic intertwines,

🐇 A rabbit hops, through the lines.

With each leap, a mapping set,

Zones aligned, without a fret.

🌟 To celebrate, we hop and twirl,

In a digital world, our contributions unfurl."

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
quicksilver	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Mar 5, 2024 8:12am

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 62f89c9 and f723673.

Files selected for processing (2)

• app/upgrades/upgrades.go (1 hunks)
• app/upgrades_test.go (1 hunks)

Additional comments: 2

app/upgrades/upgrades.go (1)

• 278-281: The implementation of V010600UpgradeHandler correctly iterates over zones and sets local denom zone mappings using the SetLocalDenomZoneMapping method. However, it's important to ensure that the SetLocalDenomZoneMapping method correctly handles the mapping logic as expected, including any edge cases or error handling that might be necessary.

app/upgrades_test.go (1)

• 373-377: The test TestV010600UpgradeHandler correctly validates the retrieval of local denom zone mapping after the upgrade handler is executed. This ensures that the new functionality introduced in the V010600UpgradeHandler is working as expected. It's good practice to include such validation checks in tests to confirm the correctness of new features.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.16%. Comparing base (62f89c9) to head (f723673).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1229   +/-   ##
=======================================
  Coverage   63.16%   63.16%           
=======================================
  Files         171      171           
  Lines       11261    11261           
=======================================
  Hits         7113     7113           
  Misses       3425     3425           
  Partials      723      723           

Flag	Coverage Δ
unittests	63.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

[joe-bowman]

lgtm