feat: update migrate vesting accounts logic

[minhngoc274]

1. Summary

Fixes #1175

2.Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

3. Implementation details

4. How to test/use

5. Checklist

• Does the Readme need to be updated?

6. Limitations (optional)

7. Future Work (optional)

Summary by CodeRabbit

• New Features
  • Introduced account and asset migration functionality for blockchain applications, supporting vesting accounts, asset transfers, and delegation actions during migration.
• Refactor
  • Improved upgrade handling logic, including the addition of a new upgrade handler for version 1.6.0.
• Tests
  • Implemented new tests for upgrade handling logic.
• Documentation
  • Updated documentation for the NoOpHandler function.
• Chores
  • Removed unused imports in the upgrade management code.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
quicksilver	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Mar 1, 2024 2:09pm

[coderabbitai]

Walkthrough

This update enhances account and asset migration capabilities within the blockchain application, particularly focusing on vesting accounts with delegations. It includes the addition of a new upgrade version, refining migration logic to handle delegations by unbonding assets before migration and reapplying them afterward, and improving test coverage for these changes.

Changes

File Path	Change Summary
app/upgrades/types.go	Added a new constant V010600UpgradeName = "v1.6.0".
app/upgrades/upgrades.go	Removed unused imports, added V010600UpgradeHandler, updated migrateVestingAccounts, and enhanced documentation.
app/upgrades_test.go	Added stakingtypes import, InitV160TestZones function, and TestV010600UpgradeHandler for testing.
app/upgrades/account_migrations.go	Introduced functionality for migrating accounts and assets between different addresses. Includes functions for migrating vesting accounts and transferring assets.

Assessment against linked issues

Objective	Addressed	Explanation
Update migrateVestingAccounts to remove and reapply delegations (#1175)	✅

Poem

In the land of code and byte,
A rabbit hopped through the night.
With a leap and a bound, it found a way,
To migrate accounts, come what may.

🌌 Across the blockchain, far and wide,
🐇 With every hop, it took in stride.
To upgrade and fix, with no delay,
"On to v1.6.0, hooray!" it would say.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository from git and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.13%. Comparing base (e3184a0) to head (62cf9f3).
Report is 1 commits behind head on main.

❗ Current head 62cf9f3 differs from pull request most recent head 6594211. Consider uploading reports for the commit 6594211 to get more accurate results

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1184   +/-   ##
=======================================
  Coverage   63.13%   63.13%           
=======================================
  Files         171      171           
  Lines       11205    11205           
=======================================
  Hits         7074     7074           
  Misses       3412     3412           
  Partials      719      719           

Flag	Coverage Δ
unittests	63.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between ac8c170 and f2431f1.

Files selected for processing (4)

• app/upgrades/account_migrations.go (1 hunks)
• app/upgrades/types.go (1 hunks)
• app/upgrades/upgrades.go (4 hunks)
• app/upgrades_test.go (2 hunks)

Files skipped from review as they are similar to previous changes (4)

• app/upgrades/account_migrations.go
• app/upgrades/types.go
• app/upgrades/upgrades.go
• app/upgrades_test.go

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between f2431f1 and 2031c85.

Files selected for processing (1)

• app/upgrades/account_migrations.go (1 hunks)

Files skipped from review as they are similar to previous changes (1)

• app/upgrades/account_migrations.go

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between f2431f1 and 28c08ad.

Files selected for processing (1)

• app/upgrades/account_migrations.go (1 hunks)

Files skipped from review as they are similar to previous changes (1)

• app/upgrades/account_migrations.go

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 8bb939c and f880b31.

Files selected for processing (4)

• app/upgrades/account_migrations.go (1 hunks)
• app/upgrades/types.go (1 hunks)
• app/upgrades/upgrades.go (4 hunks)
• app/upgrades_test.go (2 hunks)

Files skipped from review as they are similar to previous changes (4)

• app/upgrades/account_migrations.go
• app/upgrades/types.go
• app/upgrades/upgrades.go
• app/upgrades_test.go