Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ValidatorSelectionRewardsCallback expects non-zero rewards #977

Closed
1 of 3 tasks
joe-bowman opened this issue Dec 29, 2023 · 0 comments · Fixed by #978
Closed
1 of 3 tasks

ValidatorSelectionRewardsCallback expects non-zero rewards #977

joe-bowman opened this issue Dec 29, 2023 · 0 comments · Fixed by #978
Assignees
Labels
bug Something isn't working module: participationrewards Participation Rewards Module

Comments

@joe-bowman
Copy link
Contributor

joe-bowman commented Dec 29, 2023

Summary of Bug

The ValidatorSelectionRewardsCallback in x/participation rewards expects non-zero rewards to have been earned in the last epoch, and emits an error if zero response is received. This is atypical, but possible, and should be acceptable.

Expected Behaviour

Callback execution with zero rewards is valid and should be acceptable.

Version

v14.5.-rc2

Steps to Reproduce

Submit a ValidatorSelectionRewardsCallback with a payload containing zero rewards:

icq-provider_1  | ts=2023-12-29T15:51:46.635153648Z caller=run.go:767 worker=flusher chain=rhye-2 msg="Failed to submit; nevermind, we'll try again!" err="rpc error: code = Unknown desc = rpc error: code = Unknown desc = failed to execute message; message index: 4: no delegator rewards [cosmos/[email protected]/baseapp/baseapp.go:809] With gas wanted: '75000000' and gas used: '1218555' : unknown request"

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@joe-bowman joe-bowman added bug Something isn't working module: participationrewards Participation Rewards Module labels Dec 29, 2023
@joe-bowman joe-bowman self-assigned this Dec 29, 2023
faddat pushed a commit that referenced this issue Dec 29, 2023
* fix: permit zero rewards in validatorselectionrewardscallback; fixes #977

* fix: test should no longer expect err on zero rewards
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working module: participationrewards Participation Rewards Module
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant