Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GetAndUnmarshalProtocolData and MarshalAndSetProtocolData methods #1631

Closed
joe-bowman opened this issue May 23, 2024 · 1 comment · Fixed by #1681
Closed

Add GetAndUnmarshalProtocolData and MarshalAndSetProtocolData methods #1631

joe-bowman opened this issue May 23, 2024 · 1 comment · Fixed by #1681

Comments

@joe-bowman
Copy link
Contributor

Getting and Setting protocol data involves lots of repeated logic. We can simplify and bunch of code with functions that combine the two actions.
@tuantran1702 tuantran1702 mentioned this issue May 28, 2024
Closed
5 tasks
odeke-em added a commit to orijtech/quicksilver that referenced this issue Jun 29, 2024
@odeke-em
refactor((x/participationrewards/keeper): combine GetProtocolData+Unm…
a3376df 
…arshalProtocolData

This change combines GetProtocolData and types.UnmarshalProtocolData
into a generic function that unifies the functionality and the pattern.

Fixes quicksilver-zone#1631
@odeke-em odeke-em mentioned this issue Jun 29, 2024
Merged
@odeke-em
Copy link
Contributor

I've mailed out #1681

odeke-em added a commit to orijtech/quicksilver that referenced this issue Jun 29, 2024
@odeke-em
refactor((x/participationrewards/keeper): combine GetProtocolData+Unm…
89f5f93 
…arshalProtocolData

This change combines GetProtocolData and types.UnmarshalProtocolData
into a generic function that unifies the functionality and the pattern.

Fixes quicksilver-zone#1631
odeke-em added a commit to orijtech/quicksilver that referenced this issue Jun 29, 2024
@odeke-em
refactor((x/participationrewards/keeper): combine GetProtocolData+Unm…
b028e69 
…arshalProtocolData

This change combines GetProtocolData and types.UnmarshalProtocolData
into a generic function that unifies the functionality and the pattern.

Fixes quicksilver-zone#1631
odeke-em added a commit to orijtech/quicksilver that referenced this issue Jun 29, 2024
@odeke-em
refactor(x/participationrewards/keeper): combine GetProtocolData+Unma…
3d4753c 
…rshalProtocolData

This change combines GetProtocolData and types.UnmarshalProtocolData
into a generic function that unifies the functionality and the pattern.

Fixes quicksilver-zone#1631
odeke-em added a commit to orijtech/quicksilver that referenced this issue Jun 29, 2024
@odeke-em
refactor(x/participationrewards/keeper): combine GetProtocolData+Unma…
bbdbc3f 
…rshalProtocolData

This change combines GetProtocolData and types.UnmarshalProtocolData
into a generic function that unifies the functionality and the pattern.

Fixes quicksilver-zone#1631
odeke-em added a commit to orijtech/quicksilver that referenced this issue Jun 29, 2024
@odeke-em
refactor(x/participationrewards/keeper): combine GetProtocolData+Unma…
79a0d1b 
…rshalProtocolData

This change combines GetProtocolData and types.UnmarshalProtocolData
into a generic function that unifies the functionality and the pattern.

Fixes quicksilver-zone#1631
odeke-em added a commit to orijtech/quicksilver that referenced this issue Jun 30, 2024
@odeke-em
refactor(x/participationrewards/keeper): combine GetProtocolData+Unma…
f790f7f 
…rshalProtocolData

This change combines GetProtocolData and types.UnmarshalProtocolData
into a generic function that unifies the functionality and the pattern.

Fixes quicksilver-zone#1631
odeke-em added a commit to orijtech/quicksilver that referenced this issue Jul 13, 2024
@odeke-em
refactor(x/participationrewards/keeper): combine GetProtocolData+Unma…
7062aa7 
…rshalProtocolData

This change combines GetProtocolData and types.UnmarshalProtocolData
into a generic function that unifies the functionality and the pattern.

Fixes quicksilver-zone#1631
odeke-em added a commit to orijtech/quicksilver that referenced this issue Jul 13, 2024
@odeke-em
refactor(x/participationrewards/keeper): combine GetProtocolData+Unma…
4612067 
…rshalProtocolData

This change combines GetProtocolData and types.UnmarshalProtocolData
into a generic function that unifies the functionality and the pattern.

Fixes quicksilver-zone#1631
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@joe-bowman @odeke-em