Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A long delay in ibc acknowledgements can result in redelegation record GC race condition #1140

Closed
joe-bowman opened this issue Feb 13, 2024 · 0 comments · Fixed by #1141
Closed
Assignees
Labels
bug Something isn't working module: interchainstaking
Milestone

Comments

@joe-bowman
Copy link
Contributor

Problem:

Redelegation records are garbage collected if they are not acknowledged and the time that elapsed since the record was created is greater than the unbonding period. However, if acknowledgements have stalled (e.g. behind another bug) this can lead to the redelegation record being deleted and then successfully acknowledged.

Solution:

In this event, we have enough info to recreate the redelegation record from the contents of the acknowledged message, so it does not make sense in this case to error, but rather we should recreate the record and persist it.

@joe-bowman joe-bowman added bug Something isn't working module: interchainstaking labels Feb 13, 2024
@joe-bowman joe-bowman added this to the v1.5.0 milestone Feb 13, 2024
joe-bowman pushed a commit that referenced this issue Feb 13, 2024
@joe-bowman joe-bowman self-assigned this Feb 13, 2024
joe-bowman pushed a commit that referenced this issue Feb 13, 2024
faddat added a commit that referenced this issue Feb 13, 2024
…record was garbage collected (#1141)

* fix #1140; recreate redelegation record if long delays mean original record was garbage collected

* add test for redelegation record creation

---------

Co-authored-by: Jacob Gadikian <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working module: interchainstaking
Projects
None yet
1 participant