fix: defensive checks in UpdateWithdrawalRecordsForSlash; add tests; f…

…ixes #607

utils/strings.go

@@ -8,12 +8,3 @@ func StringSliceToMap(in []string) map[string]bool {
 	}
 	return out
 }
-
-// create a map from a slice of strings for efficient lookup
-func StringSliceToMap(in []string) map[string]bool {
-	out := make(map[string]bool, len(in))
-	for _, i := range in {
-		out[i] = true
-	}
-	return out
-}

x/interchainstaking/keeper/withdrawal_record.go

@@ -7,7 +7,6 @@ import (
 	"time"
 
 	sdkmath "cosmossdk.io/math"
-
 	"github.com/cosmos/cosmos-sdk/store/prefix"
 	sdk "github.com/cosmos/cosmos-sdk/types"
 

x/interchainstaking/keeper/withdrawal_record_test.go

@@ -2,9 +2,7 @@ package keeper_test
 
 import (
 	"cosmossdk.io/math"
-
 	sdk "github.com/cosmos/cosmos-sdk/types"
-
 	icskeeper "github.com/quicksilver-zone/quicksilver/x/interchainstaking/keeper"
 	"github.com/quicksilver-zone/quicksilver/x/interchainstaking/types"
 )