for xml charset and bug of "Incorrect NumInGroup" #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The "Incorrect NumInGroup" fix should be merged |
|
@demget please rebase and add a test to verify. |
albertsundjaja
pushed a commit
to albertsundjaja/quickfix
that referenced
this pull request
Apr 10, 2024
partly revert change in quickfixgo#368 due to breaking the unit test added in this PR
albertsundjaja
pushed a commit
to albertsundjaja/quickfix
that referenced
this pull request
Apr 10, 2024
partly revert change in quickfixgo#368 due to breaking the unit test added in this PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for "Incorrect NumInGroup"
#366
#365
for xml charset:
#363