Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement: First field in repeating group as delimiter #674

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Enhancement: First field in repeating group as delimiter #674

wants to merge 6 commits into from

Conversation

andreydp
Copy link

@andreydp andreydp commented Sep 12, 2023 •
edited by chrjohn
Loading

Fixes #675

@andreydp andreydp mentioned this pull request Sep 12, 2023
Open
@andreydp andreydp changed the title First field in repeating group as delimiter Enhancement: First field in repeating group as delimiter Sep 12, 2023
@quickfix-j quickfix-j deleted a comment from andreydp Sep 13, 2023
@chrjohn
Copy link
Member

chrjohn commented Sep 13, 2023

Thanks for the PR! 👍
Could you please also add the configuration to the validation section of https://github.com/quickfix-j/quickfixj/blob/master/quickfixj-core/src/main/doc/usermanual/usage/configuration.html

Thanks in advance

@andreydp
Copy link
Author

Thanks, I've added changes to the documentation and also added session parameter.

chrjohn
chrjohn requested changes Sep 18, 2023
View reviewed changes
Copy link
Member

@chrjohn chrjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please check my comments. Thank you. :)

quickfixj-core/src/test/java/quickfix/DataDictionaryTest.java Outdated Show resolved Hide resolved
quickfixj-core/src/test/java/quickfix/DataDictionaryTest.java Show resolved Hide resolved
quickfixj-core/src/main/java/quickfix/Message.java Outdated Show resolved Hide resolved
quickfixj-core/src/main/java/quickfix/DataDictionary.java Outdated Show resolved Hide resolved
@andreydp
Copy link
Author

Thanks for the review, pushed changes to the branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrjohn chrjohn Awaiting requested review from chrjohn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ability to set repeating group delimiter dynamically by using first tag of the first group
2 participants
@andreydp @chrjohn