Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove slf4j-jdk14 from examples and distribution module #615

Merged
merged 2 commits into from
Feb 28, 2023

Conversation

chrjohn
Copy link
Member

@chrjohn chrjohn commented Feb 27, 2023

See #566 (comment) and following comments.

This should correct the NullPointerException during builds with the -PskipBundlePlugin profile.

@chrjohn chrjohn changed the title Remove slf-jdk14 from examples and distribution module Remove slf4j-jdk14 from examples and distribution module Feb 27, 2023
@the-thing
Copy link
Contributor

There is a reference to slf4j-jdk14 in quickfixj-core/src/main/doc/usermanual/installation.html which is probably not required anymore.

@chrjohn chrjohn added this to the QFJ 3.0.0 milestone Feb 28, 2023
@chrjohn
Copy link
Member Author

chrjohn commented Feb 28, 2023

@the-thing , thanks for the pointer. I realized that whole document is outdated. I've added a note to #237.

@chrjohn chrjohn merged commit dce91e6 into master Feb 28, 2023
@chrjohn chrjohn deleted the chrjohn-remove-slf4j-jdk14 branch February 28, 2023 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants