fix: CachyOS downloads #1483
Merged
fix: CachyOS downloads #1483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
only two versions now - updates to new cdn setup current fails on on kde although muddles through on on transition reroutes on other two, for now.
TuxVinyards
added a commit
to TuxVinyards/qqX
that referenced
this pull request
Oct 17, 2024
philclifford
requested changes
Oct 17, 2024
quickget
Outdated
| echo "${URL}/${REL}/${ISO} ${HASH}" | ||
| local URL="" | ||
| local ISO="" | ||
| URL="$(web_pipe "https://cachyos.org/download/" | tr '&' '\n' | grep "ISO/${EDITION}" | cut -d';' -f2)" |
There was a problem hiding this comment.
Suggested change
| URL="$(web_pipe "https://cachyos.org/download/" | tr '&' '\n' | grep "ISO/${EDITION}" | cut -d';' -f2)" | |
| URL="$(web_pipe "https://cachyos.org/download/" | tr '&' '\n' | grep -o -E "https://[[:alnum:]]+\.cachyos\.org/ISO/${EDITION}/[[:digit:]]+/.*\.iso" )" |
quickget
Outdated
| local URL="" | ||
| local ISO="" | ||
| URL="$(web_pipe "https://cachyos.org/download/" | tr '&' '\n' | grep "ISO/${EDITION}" | cut -d';' -f2)" | ||
| ISO="$(basename "${ISO}")" |
There was a problem hiding this comment.
${ISO} at this point == "" and is local and not used anymore ...
1 task
legacy from previous that somehow got left in ....
There are only two links visible on a web scrape. The others with similar names are embedded in .js menus. Add a filter for these other similarities in case, in the future, the other links become visible. Other filters like ensuring there are digits in the file name could cause future breakage if the format or format sequence became changed.
philclifford
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to new cdn
fixes empty elements in urls eg. https://mirror.cachyos.org/ISO/kde///cachyos-kde-linux-.iso
Checklist: